Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Added improved JVM runtime metrics dashboard. #162460

Merged
merged 3 commits into from Jul 26, 2023

Conversation

AlexanderWert
Copy link
Member

Summary

Replaces the current JVM runtime metrics dashboard with a more advanced dashboard (based on the portable dashboards feature).

Additional information (that has not been shown in the previous view):

  • memory allocation rate
  • Heap usage split by memory pools
image image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@AlexanderWert AlexanderWert added the Team:APM All issues that need APM UI Team support label Jul 25, 2023
@AlexanderWert AlexanderWert requested a review from a team as a code owner July 25, 2023 08:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 (with a small change)

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@AlexanderWert AlexanderWert enabled auto-merge (squash) July 26, 2023 11:24
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1462 1463 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.6MB 3.7MB +54.0KB
Unknown metric groups

async chunk count

id before after diff
apm 30 31 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@AlexanderWert AlexanderWert merged commit 5d7ea97 into elastic:main Jul 26, 2023
23 checks passed
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Jul 26, 2023
rshen91 pushed a commit to rshen91/kibana that referenced this pull request Jul 26, 2023
## Summary

Replaces the current JVM runtime metrics dashboard with a more advanced
dashboard (based on the portable dashboards feature).

Additional information (that has not been shown in the previous view):
- memory allocation rate
- Heap usage split by memory pools

<img width="1428" alt="image"
src="https://github.com/elastic/kibana/assets/866830/c147f9c4-b115-455e-a86e-c288a94e25cb">
<img width="1424" alt="image"
src="https://github.com/elastic/kibana/assets/866830/3ff8978f-917f-4b5e-bd82-fe3a52fe78c7">

---------

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
## Summary

Replaces the current JVM runtime metrics dashboard with a more advanced
dashboard (based on the portable dashboards feature).

Additional information (that has not been shown in the previous view):
- memory allocation rate
- Heap usage split by memory pools

<img width="1428" alt="image"
src="https://github.com/elastic/kibana/assets/866830/c147f9c4-b115-455e-a86e-c288a94e25cb">
<img width="1424" alt="image"
src="https://github.com/elastic/kibana/assets/866830/3ff8978f-917f-4b5e-bd82-fe3a52fe78c7">

---------

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@gbamparop gbamparop added the apm:test-plan-8.10.0 APM UI Test Plan for v8.10.0 label Aug 7, 2023
@gbamparop
Copy link
Contributor

gbamparop commented Aug 31, 2023

@gbamparop gbamparop added the apm:test-plan-done Pull request that was successfully tested during the test plan label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:test-plan-8.10.0 APM UI Test Plan for v8.10.0 apm:test-plan-done Pull request that was successfully tested during the test plan backport:skip This commit does not require backporting release_note:enhancement Team:APM All issues that need APM UI Team support v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants