Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] AIOps: Improves table hovering for log rate analysis #162941

Merged

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Aug 2, 2023

Summary

Part of #160247.

Improves the table hovering behavior for log rate analysis:

  • When no row is hovered, it falls back to set the first row of the current page to a hovered state. The result is that users will always see a comparison view in the main document count chart.
  • When a row gets pinned, the hovering of the other rows will be disabled, so the comparison view in the main document count chart gets locked on the pinned row.

Before:

aiops-results-table-hovering-before-0001

After:

aiops-results-table-hovering-after-0001

Checklist

@walterra walterra added release_note:enhancement :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.10.0 labels Aug 2, 2023
@walterra walterra self-assigned this Aug 2, 2023
@walterra walterra requested a review from a team as a code owner August 2, 2023 07:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 539.9KB 540.3KB +488.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
aiops 21 23 +2

Total ESLint disabled count

id before after diff
aiops 21 23 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM

@walterra walterra merged commit b8bb4ee into elastic:main Aug 8, 2023
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 8, 2023
@walterra walterra deleted the 160247-ml-aiops-tweak-table-hovering branch August 8, 2023 08:31
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Aug 8, 2023
…2941)

Improves the table hovering behavior for log rate analysis:
- When no row is hovered, it falls back to set the first row of the
current page to a hovered state. The result is that users will always
see a comparison view in the main document count chart.
- When a row gets pinned, the hovering of the other rows will be
disabled, so the comparison view in the main document count chart gets
locked on the pinned row.
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
…2941)

Improves the table hovering behavior for log rate analysis:
- When no row is hovered, it falls back to set the first row of the
current page to a hovered state. The result is that users will always
see a comparison view in the main document count chart.
- When a row gets pinned, the hovering of the other rows will be
disabled, so the comparison view in the main document count chart gets
locked on the pinned row.
@szabosteve szabosteve changed the title [ML] AIOps: Improve table hovering for log rate analysis. [ML] AIOps: Improves table hovering for log rate analysis Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:enhancement v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants