New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Observability AI Assistant] Feature controls #163232
[Observability AI Assistant] Feature controls #163232
Conversation
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…bana into assistant-feature-controls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Profiling changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a bit more information about the different components of AI Assistant both client and server side?
The feature controls you have introduced as part of this PR only seem to be toggling the UI so I would like to understand a bit better what services this feature uses.
@thomheymann There are two client-side features:
We'll have the following APIs:
Can you elaborate on:
it is my understanding that the privileges object also gives access to APIs, by virtue of an I've also asked this on Slack, but adding here for posterity: what is the recommended way to gate this entire feature behind an enterprise license? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infra changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Perfect, yeh, this is the best way of protecting your endpoint. As long as all API routes related to this feature are using the correct access tags, users that don't have the required permissions to use the feature won't be able to work around that by calling the APIs directly. I just wanted to ensure that is the case since I didn't see these in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
security changes LGTM
This adds feature controls for the AI Assistant feature. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This adds feature controls for the AI Assistant feature. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This adds feature controls for the AI Assistant feature.