Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Settings public API #163400

Merged
merged 10 commits into from Oct 23, 2023
Merged

[Uptime] Settings public API #163400

merged 10 commits into from Oct 23, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 8, 2023 •
edited

Summary

fixes #162578

Settings public API !!

Also got an idea , in the effort involved for https://github.com/elastic/synthetics-dev/issues/247

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 changed the title [Uptime] Settings POC [Uptime] Settings public API Oct 17, 2023
@shahzad31 shahzad31 added release_note:feature Makes this part of the condensed release notes v8.12.0 labels Oct 17, 2023
@shahzad31 shahzad31 marked this pull request as ready for review October 17, 2023 06:40
@shahzad31 shahzad31 requested review from a team as code owners October 17, 2023 06:40
fkanout
fkanout reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@fkanout fkanout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AO changes LGTM with code review only.

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 17, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

awahab07
awahab07 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tested the UI as well as hitting the API endpoint publicly and it works as expected.

x-pack/plugins/uptime/server/legacy_uptime/uptime_server.ts Outdated Show resolved Hide resolved
@shahzad31 shahzad31 enabled auto-merge (squash) October 23, 2023 12:02
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 864.5KB 864.6KB +143.0B
uptime 478.3KB 478.4KB +58.0B
total +201.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
uptime 22.6KB 22.7KB +49.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 882e0bf into elastic:main Oct 23, 2023
37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 23, 2023
@shahzad31 shahzad31 deleted the dynamic-settings branch October 27, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

@fkanout fkanout fkanout approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API] Provide public API to update Uptime index pattern settings
7 participants
@shahzad31 @apmmachine @elasticmachine @kibana-ci @awahab07 @fkanout @kibanamachine