[SLO] Add support for group by to SLO burn rate rule #163434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…d-support-for-group-by-to-burn-rate-rule
…he SavedObjects client; added callout for group by rules
…d-support-for-group-by-to-burn-rate-rule
…d-support-for-group-by-to-burn-rate-rule
kdelemme
reviewed
Aug 9, 2023
x-pack/plugins/observability/public/components/burn_rate_rule_editor/burn_rate_rule_editor.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability/public/hooks/slo/use_fetch_slo_definitions.ts
Show resolved
Hide resolved
|
I have created an SLO with a groupBy and a rule on it which seems to trigger, but in the SLO details page, under the Alerts tab, I see nothing (notice the [1] notifcation badge))
|
simianhacker
added
release_note:enhancement
Team: Actionable Observability - DEPRECATED
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
kdelemme
reviewed
Aug 9, 2023
x-pack/plugins/observability/public/hooks/slo/use_fetch_active_alerts.ts
Show resolved
Hide resolved
kdelemme
approved these changes
Aug 9, 2023
x-pack/plugins/observability/public/hooks/slo/use_fetch_active_alerts.ts
Outdated
Show resolved
Hide resolved
…d-support-for-group-by-to-burn-rate-rule
kdelemme
approved these changes
Aug 9, 2023
| import { useKibana } from '../../utils/kibana_react'; | ||
| import { sloKeys } from './query_key_factory'; | ||
|
|
||
| type SLO = Pick<SLOResponse, 'id' | 'instanceId'>; | ||
|
|
||
| export class ActiveAlerts { |
…d-support-for-group-by-to-burn-rate-rule
…d-support-for-group-by-to-burn-rate-rule
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
simianhacker
deleted the
issue-163120-add-support-for-group-by-to-burn-rate-rule
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #163120 by adding support for group by's to the SLO Burn Rate rule. I refactored the rule to push all the executions down to Elasticsearch, it uses the same technique as the Metric Threshold rule. I also added a callout to the rule form to let the user know when they've selected an SLO with a group by so it's clear what the behavior will be.