Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds a throughput description in the Trained Models Deployment stats table #163481

Merged
merged 2 commits into from Aug 10, 2023
Merged

[ML] Adds a throughput description in the Trained Models Deployment stats table #163481

merged 2 commits into from Aug 10, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Aug 9, 2023 •
edited

Summary

Resolves #161828

Adds a tooltip for the Throughput column explaining units.

image

Checklist

@darnautov darnautov added release_note:enhancement :ml Feature:3rd Party Models ML 3rd party models Team:ML Team label for ML (also use :ml) v8.10.0 labels Aug 9, 2023
@darnautov darnautov requested a review from a team as a code owner August 9, 2023 11:54
@darnautov darnautov self-assigned this Aug 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

szabosteve
szabosteve approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a suggestion based on this document. Please have a look and let me know what you think.
BTW I also have an open issue with this request. Thank you @darnautov for addressing this!

x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx Show resolved Hide resolved
peteharverson
peteharverson approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov darnautov enabled auto-merge (squash) August 10, 2023 08:02
@darnautov darnautov merged commit 92d4a6d into elastic:main Aug 10, 2023
21 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +332.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 10, 2023
@darnautov darnautov deleted the ml-161828-throughput-units branch August 10, 2023 09:17
@peteharverson peteharverson changed the title [ML] Add a throughput description in the Deployment stats table [ML] Adds a throughput description in the Trained Models Deployment stats table Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabosteve szabosteve szabosteve approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting Feature:3rd Party Models ML 3rd party models :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Add throughput units to trained model stats
7 participants
@darnautov @elasticmachine @kibana-ci @peteharverson @jgowdyelastic @szabosteve @kibanamachine