Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Fix 404 not found monitor view #163501

Merged
merged 1 commit into from Aug 9, 2023

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Aug 9, 2023

Summary

Before

image

After

image

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review August 9, 2023 15:16
@shahzad31 shahzad31 requested a review from a team as a code owner August 9, 2023 15:16
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Aug 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 9d6ebdd into elastic:main Aug 9, 2023
26 checks passed
@shahzad31 shahzad31 deleted the not-found-404 branch August 9, 2023 16:21
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.9 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 163501

Questions ?

Please refer to the Backport tool documentation

@shahzad31
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Aug 9, 2023
shahzad31 added a commit that referenced this pull request Aug 10, 2023
# Backport

This will backport the following commits from `main` to `8.9`:
- [[Synthetics] Fix 404 not found monitor view
(#163501)](#163501)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2023-08-09T16:21:37Z","message":"[Synthetics]
Fix 404 not found monitor view
(#163501)","sha":"9d6ebdda4e630f0973ab6ece2803a878cea09227","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:uptime","v8.10.0","v8.9.1"],"number":163501,"url":"#163501
Fix 404 not found monitor view
(#163501)","sha":"9d6ebdda4e630f0973ab6ece2803a878cea09227"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#163501
Fix 404 not found monitor view
(#163501)","sha":"9d6ebdda4e630f0973ab6ece2803a878cea09227"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.9.1 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants