Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Make service group saved objects exportable #163569

Merged
merged 1 commit into from Aug 11, 2023
Merged

[APM] Make service group saved objects exportable #163569

merged 1 commit into from Aug 11, 2023

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Aug 10, 2023 •
edited

  • Makes the saved objects used by service groups exportable / importable
  • Adds a link from the saved object to the service group page
  • Renames the saved objects from APM Service Groups to Service Group: ${service_group_name}

Before

Screen.Recording.2023-08-10.at.11.09.22.mov

After

Screen.Recording.2023-08-10.at.11.07.52.mov

Closes #163576

@gbamparop gbamparop added the release_note:feature Makes this part of the condensed release notes label Aug 10, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gbamparop gbamparop marked this pull request as ready for review August 10, 2023 10:12
@gbamparop gbamparop requested a review from a team as a code owner August 10, 2023 10:12
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Aug 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@sorenlouv
Copy link
Member

sorenlouv commented Aug 10, 2023 •
edited

Can you also add the curl commands for exporting/importing the service groups programatically?

@gbamparop
Copy link
Contributor Author

Can you also add the curl commands for exporting/importing the service groups programatically?

They are mentioned in the issue.

@gbamparop gbamparop merged commit 290bf1d into elastic:main Aug 11, 2023
26 checks passed
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 11, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 11, 2023
@jloleysens
Merge branch 'main' into send-build-number-in-header
832af82 
* main: (64 commits)
  [ML] Transforms: Fix privileges check. (elastic#163687)
  [Log Explorer] Add test suite for Dataset Selector (elastic#163079)
  [Security Solution][Endpoint] Add API checks to Endpoint Policy create/update for checking `endpointPolicyProtections` is enabled (elastic#163429)
  [Security Solution] Fix flaky test: x-pack/test/detection_engine_api_integration/security_and_spaces/update_prebuilt_rules_package/update_prebuilt_rules_package·ts - update_prebuilt_rules_package should allow user to install prebuilt rules from scratch, then install new rules and upgrade existing rules from the new package (elastic#163241)
  [Security Solution] expandable flyout - replace feature flag with advanced settings toggle (elastic#161614)
  [DOCS] Adds the release notes for the 8.9.1 release. (elastic#163578)
  [FTR] Implement browser network condition utils (elastic#163633)
  [Security Solution] Unskip rules table auto-refresh Cypress tests (elastic#163451)
  [Security Solution] Re-enable fixed rule snoozing Cypress test (elastic#160037)
  [Flaky Test elastic#111821] Mock `moment` to avoid midnight TZ issues (elastic#163157)
  Document interactive setup (elastic#163619)
  [Lens] Align decoration color with text color for layer actions (elastic#163630)
  [Lens] Relax counter field checks for saved visualizations with unsupported operations (elastic#163515)
  [Security Solution][Endpoint] Removes pMap and uses a for loop instead (elastic#163509)
  [Enterprise Search] Update Workplace Search connectors doclink (elastic#163676)
  Update APM (main) (elastic#163623)
  [Serverless] Partially fix lens/maps/visualize breadcrumbs missing title  (elastic#163476)
  [Flaky elastic#118272] Unskip tests (elastic#163319)
  [APM] Make service group saved objects exportable (elastic#163569)
  [Observability AI Assistant] Action menu item (elastic#163463)
  ...
benakansara pushed a commit to benakansara/kibana that referenced this pull request Aug 14, 2023
@gbamparop @benakansara
[APM] Make service group saved objects exportable (elastic#163569)
cbcbed1 
- Makes the saved objects used by service groups exportable / importable
- Adds a link from the saved object to the service group page
- Renames the saved objects from `APM Service Groups` to `Service Group:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:APM All issues that need APM UI Team support v8.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Make saved objects used for service groups exportable
6 participants
@gbamparop @apmmachine @kibana-ci @elasticmachine @sorenlouv @kibanamachine