[8.9] fix(NA): yarn env vars for node_modules mirrors (#163549) #163617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the setup we have for the node_module mirrors vars that are overriding and pointing into our middle cache. The previous configuration was not working as intended as the env vars set globally on CI never ended up in the bazel managed yarn install. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 17936ff)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @mistic |
mistic
added a commit
that referenced
this pull request
Aug 15, 2023
…3897) # Backport This will backport the following commits from `main` to `7.17`: - [fix(NA): yarn env vars for node_modules mirrors (#163549)](#163549) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"tiago.costa@elastic.co"},"sourceCommit":{"committedDate":"2023-08-10T14:35:34Z","message":"fix(NA): yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the setup we have for the node_module mirrors vars that\r\nare overriding and pointing into our middle cache. The previous\r\nconfiguration was not working as intended as the env vars set globally\r\non CI never ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:all-open","v8.10.0","v8.9.1"],"number":163549,"url":"#163549: yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the setup we have for the node_module mirrors vars that\r\nare overriding and pointing into our middle cache. The previous\r\nconfiguration was not working as intended as the env vars set globally\r\non CI never ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#163549: yarn env vars for node_modules mirrors (#163549)\n\nThis PR fixes the setup we have for the node_module mirrors vars that\r\nare overriding and pointing into our middle cache. The previous\r\nconfiguration was not working as intended as the env vars set globally\r\non CI never ended up in the bazel managed yarn install.\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"17936ffd21d4b4b274d2cda90902764ed0d4ae07"}},{"branch":"8.9","label":"v8.9.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"#163617 fix(NA): yarn env vars for node_modules mirrors (#163549) (#163617)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.9`:\n- [fix(NA): yarn env vars for node_modules mirrors\n(#163549)](https://github.com/elastic/kibana/pull/163549)\n\n<!--- Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Tiago\nCosta\",\"email\":\"tiago.costa@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2023-08-10T14:35:34Z\",\"message\":\"fix(NA):\nyarn env vars for node_modules mirrors (#163549)\\n\\nThis PR fixes the\nsetup we have for the node_module mirrors vars that\\r\\nare overriding\nand pointing into our middle cache. The previous\\r\\nconfiguration was\nnot working as intended as the env vars set globally\\r\\non CI never\nended up in the bazel managed yarn install.\\r\\n\\r\\nCo-authored-by:\nKibana Machine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"17936ffd21d4b4b274d2cda90902764ed0d4ae07\",\"branchLabelMapping\":{\"^v8.10.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"chore\",\"Team:Operations\",\"release_note:skip\",\"backport:all-open\",\"v8.10.0\"],\"number\":163549,\"url\":\"#163549 env vars for node_modules mirrors (#163549)\\n\\nThis PR fixes the\nsetup we have for the node_module mirrors vars that\\r\\nare overriding\nand pointing into our middle cache. The previous\\r\\nconfiguration was\nnot working as intended as the env vars set globally\\r\\non CI never\nended up in the bazel managed yarn install.\\r\\n\\r\\nCo-authored-by:\nKibana Machine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"17936ffd21d4b4b274d2cda90902764ed0d4ae07\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v8.10.0\",\"labelRegex\":\"^v8.10.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"#163549 env vars for node_modules mirrors (#163549)\\n\\nThis PR fixes the\nsetup we have for the node_module mirrors vars that\\r\\nare overriding\nand pointing into our middle cache. The previous\\r\\nconfiguration was\nnot working as intended as the env vars set globally\\r\\non CI never\nended up in the bazel managed yarn install.\\r\\n\\r\\nCo-authored-by:\nKibana Machine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"17936ffd21d4b4b274d2cda90902764ed0d4ae07\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Tiago Costa <tiago.costa@elastic.co>"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.9:Questions ?
Please refer to the Backport tool documentation