Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixes query bar not switching from KQL to Lucene and vice versa in Anomaly explorer #163625

Merged
merged 4 commits into from Aug 18, 2023

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Aug 10, 2023

Summary

Addresses #131007 and fixes the Explorer query bar not switching from KQL to Lucene and vice versa in Anomaly explorer wizard

After:

Screen.Recording.2023-08-10.at.10.17.25.mov

Checklist

Delete any items that are not applicable to this PR.

Fixes #131007

@qn895 qn895 requested a review from a team as a code owner August 10, 2023 15:18
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@peteharverson peteharverson changed the title [ML] Fix Explorer query bar not switching from KQL to Lucene and vice versa in Anomaly explorer wizard [ML] Fix query bar not switching from KQL to Lucene and vice versa in Anomaly explorer Aug 10, 2023
@qn895
Copy link
Member Author

qn895 commented Aug 11, 2023

@elasticmachine merge upstream

@qn895
Copy link
Member Author

qn895 commented Aug 15, 2023

@elasticmachine merge upstream

@qn895
Copy link
Member Author

qn895 commented Aug 18, 2023

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@qn895 qn895 enabled auto-merge (squash) August 18, 2023 15:49
@qn895 qn895 merged commit 5cfb693 into elastic:main Aug 18, 2023
23 of 24 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +9.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
ml 564 565 +1

Total ESLint disabled count

id before after diff
ml 567 568 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 18, 2023
kibanamachine added a commit that referenced this pull request Aug 18, 2023
…ersa in Anomaly explorer (#163625) (#164247)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[ML] Fix query bar not switching from KQL to Lucene and vice versa in
Anomaly explorer
(#163625)](#163625)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Quynh Nguyen
(Quinn)","email":"43350163+qn895@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-18T16:52:25Z","message":"[ML]
Fix query bar not switching from KQL to Lucene and vice versa in Anomaly
explorer
(#163625)","sha":"5cfb693701a3b26d3ea9c4879707135cf23a1e84","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly
Detection","v8.10.0","v8.11.0"],"number":163625,"url":"#163625
Fix query bar not switching from KQL to Lucene and vice versa in Anomaly
explorer
(#163625)","sha":"5cfb693701a3b26d3ea9c4879707135cf23a1e84"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"#163625
Fix query bar not switching from KQL to Lucene and vice versa in Anomaly
explorer
(#163625)","sha":"5cfb693701a3b26d3ea9c4879707135cf23a1e84"}},{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Quynh Nguyen (Quinn) <43350163+qn895@users.noreply.github.com>
@szabosteve szabosteve changed the title [ML] Fix query bar not switching from KQL to Lucene and vice versa in Anomaly explorer [ML] Fixes query bar not switching from KQL to Lucene and vice versa in Anomaly explorer Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Anomaly explorer & Data visualizer's filters stuck when switching between KQL & Lucene
6 participants