Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Allow custom roles to use image reporting in dashboard #163873

Merged
merged 7 commits into from Aug 15, 2023
Merged

[Reporting] Allow custom roles to use image reporting in dashboard #163873

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f441418
fix custom roles image reporting in dashboard
rshen91 Aug 14, 2023
99e3dd7
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Aug 14, 2023
8402beb
Merge branch 'main' into reporting-share-menu
rshen91 Aug 14, 2023
17fe124
Merge branch 'main' into reporting-share-menu
rshen91 Aug 14, 2023
32ea8dd
Merge branch 'main' into reporting-share-menu
rshen91 Aug 15, 2023
2056f74
remove todo
rshen91 Aug 15, 2023
b97e1e7
Merge remote-tracking branch 'origin/reporting-share-menu' into repor…
rshen91 Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
View file
Open in desktop
Expand Up @@ -82,7 +82,6 @@ export const reportingScreenshotShareProvider = ({
let capabilityHasDashboardScreenshotReporting = false;
let capabilityHasVisualizeScreenshotReporting = false;
if (usesUiCapabilities) {
// TODO: add abstractions in ExportTypeRegistry to use here?
capabilityHasDashboardScreenshotReporting =
application.capabilities.dashboard?.generateScreenshot === true;
capabilityHasVisualizeScreenshotReporting =
Expand All @@ -106,7 +105,11 @@ export const reportingScreenshotShareProvider = ({
return [];
}

if (isSupportedType && !capabilityHasVisualizeScreenshotReporting) {
if (
isSupportedType &&
!capabilityHasVisualizeScreenshotReporting &&
!capabilityHasDashboardScreenshotReporting
Copy link
Contributor Author

@rshen91 rshen91 Aug 14, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to return an empty array for Dashboard users if they have the right permissions defined in isSupportedType

) {
return [];
}

Expand Down