New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for geo_shape fields as the entity geospatial field when creating tracking containment alerts #164100
Conversation
…creating tracking containment alerts
@elasticmachine merge upstream |
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just one thing I'm unsure about.
code review and tested with geo_shape faketracks.
x-pack/plugins/stack_alerts/server/rule_types/geo_containment/lib/transform_results.ts
Show resolved
Hide resolved
x-pack/plugins/stack_alerts/server/rule_types/geo_containment/lib/es_query_builder.ts
Show resolved
Hide resolved
@elasticmachine merge upstream |
Poking around at ZDT/migration issues:
|
@pmuellr could you provide some more details around the comment below. What actions need to happen to resolve this?
I could add a new field to store string version. That would keep |
@elasticmachine merge upstream |
That seems like the best solution for now. We're working through how to version this stuff, so that in the future we would know to not run a "upgraded" rule on an "old" kibana, so something like what's in the PR could be made to work, with some version labeling. The other thought is - how well does old code cope with a string? Worse case is the throws an error, and we may need to do some Dev Console "surgery" to fix it up (probably delete the task document). Maybe that's tolerable? |
ZDT addressed with 4ecf124. new state stored in |
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #163996
To test
node ./generate_tracks.js
tracks*
data viewtracks*
and boundaries index isboundaries
.