Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add ability to set a proxy for agent binary source #164168

Merged
merged 16 commits into from Aug 22, 2023

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Aug 17, 2023

Summary

Closes #162862

Add a proxy selector for agent download sources.

Selecting a proxy will set the agent.download.proxy_url field on the agent policy (this can be checked in the "view full agent policy" flyout). I have marked this functionality as beta as we currently can only use the URL of the proxy, not the certificates or headers.

Editing a proxy should automatically update all associated policies which use download sources with that proxy.

Deleting a proxy should remove the proxy from all associated policies.

Screenshot 2023-08-17 at 14 41 58

Verifying the field is set...

Screenshot 2023-08-17 at 14 43 38

Checklist

Delete any items that are not applicable to this PR.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@hop-dev hop-dev changed the title 162862 download source proxy selector [Fleet] Add ability to set a proxy for agent binary source Aug 17, 2023
@hop-dev hop-dev self-assigned this Aug 17, 2023
@hop-dev hop-dev added Team:Fleet Team label for Observability Data Collection Fleet team release_note:feature Makes this part of the condensed release notes v8.11.0 labels Aug 17, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1023.1KB 1.0MB +1.6KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev marked this pull request as ready for review August 17, 2023 15:39
@hop-dev hop-dev requested review from a team as code owners August 17, 2023 15:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet self-requested a review August 17, 2023 15:51
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO changes LGTM

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hop-dev hop-dev merged commit ce93a1f into elastic:main Aug 22, 2023
27 checks passed
@hop-dev hop-dev deleted the 162862-download-source-proxy-selector branch August 22, 2023 08:12
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Allow the source_uri address to be reachable via a proxy server
7 participants