[Log Explorer] Convert log explorer profile into standalone app #164493

weltenwort · 2023-08-22T17:58:02Z

📝 Summary

This converts the log explorer profile into a stand-alone log explorer component and an observability log explorer app, that uses it.

closes #164197

Release note

The Observability Log Explorer App is made available as a preview in the Observability solution navigation. It offers the usability of Discover, but is optimized for viewing log entries from log data streams.

🛠️ Implementation notes

This renames the discover_log_explorer plugin into log_explorer.
Instead of registering a discover profile, log_explorer now exports a component that renders the DiscoverContainer with the previously implemented customizations. This is where integration-level customization will go in the future. For observability-specific customizations this component will have to become a lot more configurable.
The new plugin observability_log_explorer registers a log explorer application, which renders the aforementioned log explorer component. This is where observability-specific customizations will go in the future.
The functional tests for both stateful and serverless were renamed and adapted accordingly.
The functional tests use discover page objects in many places, which is sensible because components are identical. The test utilities for this identical UX should probably be factored out into smaller, specialized page objects as the componentization of Discover progresses.
The name that the app is labelled with in the UI is still being discussed.
The search session feature is left in an uninitialized state because this injects a proxy of the search session service, which ignores the enablement call.

🎨 Previews

Stateful `/app/observability-log-explorer`

Stateless `/app/observability-log-explorer`

apmmachine · 2023-08-22T17:58:16Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…fix'

…ocs'

…-fix'

…fix'

…-ref HEAD~1..HEAD --fix'

…fix'

elasticmachine · 2023-08-29T17:50:41Z

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

jeramysoucy

Changes in test/plugin_functional/test_suites/core_plugins/rendering.ts LGTM. Just one minor nit/ask.

jeramysoucy · 2023-08-29T19:08:19Z

test/plugin_functional/test_suites/core_plugins/rendering.ts

-         * xpack.discoverLogExplorer.featureFlags is conditional and will never resolve if used in non-serverless environment
-         */
-        'xpack.discoverLogExplorer.featureFlags.deepLinkVisible (any)',
+        'xpack.observabilityLogExplorer.navigation.showAppLink (any)',


@weltenwort Could you add a short comment to explain the any type? I know we don't have them for all of the any-typed items here, but we're trying to be better about this.

jbudz

limits.yml, storybook aliases lgtm

tonyghiani

The latest changes LGTM and the features still work correctly, thanks for this work 👏

pheyos

x-pack/test_serverless/functional/config.base.ts changes LGTM

kibana-ci · 2023-08-31T12:15:32Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`discoverLogExplorer`	317	-	-317
`logExplorer`	-	319	+319
`observabilityLogExplorer`	-	32	+32
total			+34

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`logExplorer`	-	3	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discoverLogExplorer`	221.1KB	-	-221.1KB
`logExplorer`	-	220.7KB	⚠️ +220.7KB
total			-354.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`logExplorer`	-	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`discoverLogExplorer`	5.9KB	-	-5.9KB
`infra`	105.8KB	105.9KB	+78.0B
`logExplorer`	-	5.5KB	+5.5KB
`observabilityLogExplorer`	-	8.7KB	+8.7KB
`serverlessObservability`	44.1KB	44.2KB	+12.0B
total			+8.3KB

Unknown metric groups

API count

id	before	after	diff
`logExplorer`	-	3	+3

async chunk count

id	before	after	diff
`discoverLogExplorer`	8	-	-8
`logExplorer`	-	8	+8
total			-0

ESLint disabled in files

id	before	after	diff
`discoverLogExplorer`	2	-	-2
`logExplorer`	-	2	+2
total			-0

ESLint disabled line counts

id	before	after	diff
`discoverLogExplorer`	4	-	-4
`logExplorer`	-	6	+6
`observabilityLogExplorer`	-	2	+2
total			+4

Total ESLint disabled count

id	before	after	diff
`discoverLogExplorer`	6	-	-6
`logExplorer`	-	8	+8
`observabilityLogExplorer`	-	2	+2
total			+4

History

💚 Build #154790 succeeded d8e572c
💛 Build #154617 was flaky 9906a21
💔 Build #154614 failed 7cf2129
💔 Build #154472 failed 6a5c8d4
💔 Build #154155 failed 5d07c88
💔 Build #154118 failed a321268

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @weltenwort

…tic#164493) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>

weltenwort added 6 commits August 21, 2023 17:06

Rename the plugin

fc04346

Add observability_log_explorer plugin

3d077e2

Add obs log explorer server-side

6b32955

Achieve basic log explorer rendering

39b1440

Hide the nav entry for now

87cd1e5

Wrap with obs page template

4fee709

weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Aug 22, 2023

weltenwort self-assigned this Aug 22, 2023

kibanamachine and others added 16 commits August 22, 2023 18:04

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

15f9300

…fix'

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

41de574

[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…

a77ee87

…ocs'

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

6b24b5c

…-fix'

Merge branch 'main' into log-explorer-app

76ef9c9

Make deep link searchable

c676985

Add stateful log explorer link

f5fb017

Merge branch 'main' into log-explorer-app

1d7ff78

Add breadcrumbs

3e9f0c0

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

c49a4d7

…fix'

Fix filter control height and clipping

7904041

Prevent enabling the search session service

eeeceac

Add to serverless nav

7067550

Start to fix the functional tests

4198a44

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

b894bf9

…-ref HEAD~1..HEAD --fix'

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

f89e674

…fix'

This comment was marked as outdated.

Sign in to view

weltenwort added 3 commits August 25, 2023 10:38

Merge branch 'main' into log-explorer-app

ebc7d26

Initialize bundle limits

7277e81

Fix stateful functional tests

7ac3a3b

weltenwort requested review from a team as code owners August 29, 2023 17:47

jeramysoucy requested changes Aug 29, 2023

View reviewed changes

jbudz approved these changes Aug 29, 2023

View reviewed changes

tonyghiani approved these changes Aug 30, 2023

View reviewed changes

pgayvallet approved these changes Aug 30, 2023

View reviewed changes

pheyos approved these changes Aug 30, 2023

View reviewed changes

weltenwort added 3 commits August 30, 2023 09:28

Merge branch 'main' into log-explorer-app

204264c

Add comment to conditional config key in test

b192889

Remove superfluous test fixtures

d8e572c

This was referenced Aug 30, 2023

[Explorer] Remove Discover links from log explorer document fly-out #165217

Closed

[Log Explorer] Add link to fall back to Discover #165220

Closed

jeramysoucy approved these changes Aug 30, 2023

View reviewed changes

weltenwort added the release_note:feature Makes this part of the condensed release notes label Aug 30, 2023

rshen91 approved these changes Aug 30, 2023

View reviewed changes

weltenwort mentioned this pull request Aug 30, 2023

[Explorer] Extract URL state persistence from the component #165255

Closed

Merge branch 'main' into log-explorer-app

7fc1039

MiriamAparicio approved these changes Aug 31, 2023

View reviewed changes

Add beta badge to chrome

b97c53d

weltenwort merged commit ad59308 into elastic:main Aug 31, 2023
25 checks passed

weltenwort deleted the log-explorer-app branch August 31, 2023 12:18

kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Log Explorer] Convert log explorer profile into standalone app #164493

[Log Explorer] Convert log explorer profile into standalone app #164493

weltenwort commented Aug 22, 2023 •

edited

apmmachine commented Aug 22, 2023

This comment was marked as outdated.

elasticmachine commented Aug 29, 2023

jeramysoucy left a comment

jeramysoucy Aug 29, 2023

jbudz left a comment

tonyghiani left a comment

pheyos left a comment

kibana-ci commented Aug 31, 2023

API count

async chunk count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

[Log Explorer] Convert log explorer profile into standalone app #164493

[Log Explorer] Convert log explorer profile into standalone app #164493

Conversation

weltenwort commented Aug 22, 2023 • edited

📝 Summary

Release note

🛠️ Implementation notes

🎨 Previews

Stateful /app/observability-log-explorer

Stateless /app/observability-log-explorer

apmmachine commented Aug 22, 2023

🤖 GitHub comments

This comment was marked as outdated.

elasticmachine commented Aug 29, 2023

jeramysoucy left a comment

Choose a reason for hiding this comment

jeramysoucy Aug 29, 2023

Choose a reason for hiding this comment

jbudz left a comment

Choose a reason for hiding this comment

tonyghiani left a comment

Choose a reason for hiding this comment

pheyos left a comment

Choose a reason for hiding this comment

kibana-ci commented Aug 31, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

weltenwort commented Aug 22, 2023 •

edited

Stateful `/app/observability-log-explorer`

Stateless `/app/observability-log-explorer`