[Config] Acknowledge when Advanced Settings respond #16485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickypg
added
release_note:enhancement
review
Team:Core
pickypg
changed the title
💔 Build Failed |
tsullivan
reviewed
Feb 2, 2018
| }) | ||
| .catch(reason => { | ||
| localUpdate(key, initialVal, config.get(key)); | ||
| notify.error(reason); | ||
| return false; |
There was a problem hiding this comment.
is there a way to have this return value covered in a test?
There was a problem hiding this comment.
Not without exposing the change method and allowing the delayedUpdate method to be overridden, or adding the override to change and set, which is undesirable.
There was a problem hiding this comment.
I decided it was worth the effort, so I exposed change as _change and added tests for true and false scenarios.
This adds a return value to the `Promise` returned by `config.set`, which allows callers to `await` it and verify that their setting was applied without checking the settings (which is a race condition).
pickypg
force-pushed
the
feature/config-should-acknowledge-set
branch
from
1c0b7b7
to
78c2a8d
Compare
💔 Build Failed |
💚 Build Succeeded |
|
I think it might be time to rip out the delayed updater, cc @nreese |
tsullivan
approved these changes
Feb 5, 2018
pickypg
added a commit
that referenced
this pull request
Feb 5, 2018
This adds a return value to the `Promise` returned by `config.set`, which allows callers to `await` it and verify that their setting was applied without checking the settings (which is a race condition).
|
6.x/6.3: 1b4fab3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a return value to the
Promisereturned byconfig.set, which allows callers toawaitit and verify that their setting was applied without checking the settings (which is a race condition).A future update might be good to change the
notifierusage to atoastNotification, but that is a wider effort.