Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Prevent user to use decimals for custom Percentile rank function in Top values #165616

Merged
merged 2 commits into from Sep 5, 2023
Merged

[Lens] Prevent user to use decimals for custom Percentile rank function in Top values #165616

merged 2 commits into from Sep 5, 2023

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Sep 4, 2023 •
edited

Summary

Fixes #165001

Decimals are still allowed as dimension column:

Screenshot 2023-09-04 at 18 20 30

But considered invalid values when used inline in Top values as custom ranking function:

Screenshot 2023-09-04 at 18 20 44

Checklist

@dej611 dej611 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens v8.11.0 labels Sep 4, 2023
@dej611 dej611 requested a review from a team as a code owner September 4, 2023 16:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 4, 2023 •
edited

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Observability Tests / serverless common UI API keys should create and delete API keys correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB +10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, LGTM!

@dej611 dej611 merged commit 0f40b6d into elastic:main Sep 5, 2023
32 of 37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 5, 2023
@dej611 dej611 deleted the fix/165001 branch September 5, 2023 07:29
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Sep 19, 2023
@dej611 @bryce-b
[Lens] Prevent user to use decimals for custom Percentile rank functi…
00ae6e0 
…on in Top values (elastic#165616)

## Summary

Fixes elastic#165001 

Decimals are still allowed as dimension column:

<img width="336" alt="Screenshot 2023-09-04 at 18 20 30"
src="https://github.com/elastic/kibana/assets/924948/c35206ce-7413-4a26-b785-46d088322f3a">

But considered invalid values when used inline in Top values as custom
ranking function:

<img width="343" alt="Screenshot 2023-09-04 at 18 20 44"
src="https://github.com/elastic/kibana/assets/924948/aff26496-bf99-4a06-9c10-0ffe9e9e6219">


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Percentile rank with decimals allowed as custom ranking function leads to error
5 participants
@dej611 @elasticmachine @kibana-ci @stratoula @kibanamachine