[Dashboard] Generate new panel ids on Dashboard clone

[ThomThomson]

Summary

Fixes #166231

This PR ensures that all panels are given new, unique IDs when a dashboard is cloned. This will fix a bug where some panels weren't refreshed properly on navigation, since the "fast dashboard navigation" relies on IDs to be changed in order to handle the logic for deciding which panels need to be rebuilt.

Checklist

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[ThomThomson]

Closing this for now, as this bug is quite small, and the fix is fairly difficult. We can revisit this later if it becomes a priority.

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[jsanz]

I'm still experiencing this issue when using a links panel on old auditbeat dashboards

vokoscreenNG-2023-10-02_17-35-50.webm

[jsanz]

Apologies, I forgot to clone the dashboards 🤦. After that, the panels are loaded correctly

[nickpeihl]

lgtm! I just have one concern about a test.

code review and verified cloned dashboards generate new panel ids.

[ThomThomson]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: c9f4383

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
controls	302	304	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
dashboard	374.3KB	374.4KB	+94.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
controls	37.4KB	37.7KB	+246.0B
dashboard	35.6KB	35.9KB	+350.0B
total			+596.0B

Unknown metric groups

API count

id	before	after	diff
controls	309	311	+2

History

• 💔 Build #165013 failed 44ec325
• 💚 Build #164156 succeeded 3ef0ed9
• 💔 Build #164054 failed 98fc91b
• 💔 Build #163139 failed 4f56fb2
• 💔 Build #158756 failed 9f51498

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter @ThomThomson