Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maps] allow by value styling for EMS boundary fields #166306

Merged
merged 14 commits into from Sep 13, 2023
Merged

[maps] allow by value styling for EMS boundary fields #166306

merged 14 commits into from Sep 13, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Sep 12, 2023 •
edited

Closes #166305

PR:

  1. adds getFields implementation to EMSFileSource so that fields can be used for by-value styling
    Screen Shot 2023-09-12 at 4 20 44 PM
  2. removes createFields method from IVectorStyle. Duplicate of getFieldByNamd method.
  3. Refactored EMSFileSource update editor to functional component and added loading state.
    Screen Shot 2023-09-12 at 4 08 18 PM

Test instructions

  1. create map and add "EMS boundaries layer".
  2. Verify layer allows styling by-value for label with EMS property fields

@nreese nreese added the technical debt Improvement of the software architecture and operational architecture label Sep 12, 2023
@nreese nreese marked this pull request as ready for review September 13, 2023 11:55
@nreese nreese requested a review from a team as a code owner September 13, 2023 11:55
@nreese nreese added release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps labels Sep 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nickpeihl nickpeihl self-requested a review September 13, 2023 14:21
nickpeihl
nickpeihl requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we show field options for EMS boundaries when using a custom color palette?

Screenshot 2023-09-13 at 10 54 09 AM

@nreese
Copy link
Contributor Author

nreese commented Sep 13, 2023 •
edited

Can we show field options for EMS boundaries when using a custom color palette?

Good suggestion. I have added getValueSuggestions implementation to EMSFileSource. Suggestions will not be available for all fields. values is only populated for some fields, not all fields. For example, world countries populates values for iso2 and iso3 but not name and iso numeric code.

nickpeihl
nickpeihl approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested styling ems boundary fields.

@nreese nreese added the v8.11.0 label Sep 13, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
maps 261 258 -3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.8MB 2.8MB -101.0B
Unknown metric groups

API count

id before after diff
maps 262 259 -3

ESLint disabled line counts

id before after diff
maps 49 50 +1

Total ESLint disabled count

id before after diff
maps 75 76 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 1abe8c0 into elastic:main Sep 13, 2023
27 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Maps release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas technical debt Improvement of the software architecture and operational architecture v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[maps] allow by value styling for EMS boundary fields
5 participants
@nreese @elasticmachine @kibana-ci @nickpeihl @kibanamachine