fixes error with postFlightRequest #16643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
review
Feature:Visualizations
💔 Build Failed |
|
To reproduce the actual issue - since it's not documented in the original issue - you should add a new aggregation (but don't select the aggregation type yet) and then switch the time range. |
ppisljar
force-pushed
the
fix/postFlightRequest2
branch
from
34784b6
to
f57cefe
Compare
💔 Build Failed |
ppisljar
force-pushed
the
fix/postFlightRequest2
branch
from
f57cefe
to
e100bc1
Compare
|
jenkins, test this |
thomasneirynck
approved these changes
Feb 20, 2018
💚 Build Succeeded |
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Feb 23, 2018
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Feb 23, 2018
# Conflicts: # src/ui/public/vis/request_handlers/courier.js
ppisljar
added a commit
that referenced
this pull request
Feb 23, 2018
ppisljar
added a commit
that referenced
this pull request
Feb 23, 2018
|
I think it'd be good to create a test that would have caught this issue (according to the ticket, looks like a user was unable to add sub aggregations). I suspect the creation of nestedSearchSource is not necessary (I'm trying to track down the various flows of search source inheritance aInd creation, which is how I found it). A test that would cover this part of the code could also help find an issue if removing nestedSearchSource breaks anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #15912