[Fleet] Increase package install max timeout + add concurrency control to rollovers #166775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpollich
added
the
Team:Fleet
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kpollich
commented
Sep 19, 2023
Comment on lines
+109
to
+125
| if (isStatusInstalling && hasExceededTimeout) { | ||
| // If this is a forced installation, ignore the timeout and restart the installation anyway | ||
| if (force) { | ||
| await restartInstallation({ | ||
| savedObjectsClient, | ||
| pkgName, | ||
| pkgVersion, | ||
| installSource, | ||
| verificationResult, | ||
| }); | ||
| } else { | ||
| throw new ConcurrentInstallOperationError( | ||
| `Concurrent installation or upgrade of ${pkgName || 'unknown'}-${ | ||
| pkgVersion || 'unknown' | ||
| } detected, aborting.` | ||
| ); | ||
| } |
There was a problem hiding this comment.
To avoid the edge case mentioned in #166761 (comment), I'm allowing forced installation to immediately trigger a restart of a stuck installation without honoring the timeout.
juliaElastic
approved these changes
Sep 20, 2023
|
Should we backport to 8.10.2? |
We missed 8.10.2 feature freeze it looks like, and I'd like to figure out some kind of testing solution here before we ship so this won't make 8.10.2. |
I see, then maybe 8.10.3, the FF is Oct 3. |
2 tasks
|
Hmm I am on the fence about 8.10.3 here. This could probably be considered a bugfix, the more I think about it - so maybe safe to backport to that patch release. |
kpollich
commented
Sep 25, 2023
There was a problem hiding this comment.
I added tests for the "stuck in installing" timeout cases and the force flag logic changes, but I wasn't able to really land on a testing implementation to ensure we don't overwhelm the ES cluster with concurrent requests.
|
@elasticmachine merge upstream |
|
Pinging @elastic/fleet (Team:Fleet) |
kpollich
added
release_note:fix
backport:prev-minor
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpollich |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2023
…l to rollovers (elastic#166775) Fixes elastic#166761 Ref elastic#162772 ## Summary - Increase overall timeout for waiting to retry "stuck" installations from 1 minute to 30 minutes - Add `pMap` concurrency control limiting concurrent `putMapping` + `rollover` requests to mitigate ES load --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit c20d177)
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2023
… control to rollovers (#166775) (#167184) # Backport This will backport the following commits from `main` to `8.10`: - [[Fleet] Increase package install max timeout + add concurrency control to rollovers (#166775)](#166775) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kyle Pollich","email":"kyle.pollich@elastic.co"},"sourceCommit":{"committedDate":"2023-09-25T18:05:03Z","message":"[Fleet] Increase package install max timeout + add concurrency control to rollovers (#166775)\n\nFixes #166761 #162772 Summary\r\n\r\n- Increase overall timeout for waiting to retry \"stuck\" installations\r\nfrom 1 minute to 30 minutes\r\n- Add `pMap` concurrency control limiting concurrent `putMapping` +\r\n`rollover` requests to mitigate ES load\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"c20d177a036be73d7b1180dc17e644afa260994f","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","backport:prev-minor","v8.11.0"],"number":166775,"url":"#166775 Increase package install max timeout + add concurrency control to rollovers (#166775)\n\nFixes #166761 #162772 Summary\r\n\r\n- Increase overall timeout for waiting to retry \"stuck\" installations\r\nfrom 1 minute to 30 minutes\r\n- Add `pMap` concurrency control limiting concurrent `putMapping` +\r\n`rollover` requests to mitigate ES load\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"c20d177a036be73d7b1180dc17e644afa260994f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"#166775 Increase package install max timeout + add concurrency control to rollovers (#166775)\n\nFixes #166761 #162772 Summary\r\n\r\n- Increase overall timeout for waiting to retry \"stuck\" installations\r\nfrom 1 minute to 30 minutes\r\n- Add `pMap` concurrency control limiting concurrent `putMapping` +\r\n`rollover` requests to mitigate ES load\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"c20d177a036be73d7b1180dc17e644afa260994f"}}]}] BACKPORT--> --------- Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166761
Ref #162772
Summary
pMapconcurrency control limiting concurrentputMapping+rolloverrequests to mitigate ES load