[Security Solution] Fix missing hash in sync to url #166847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgestc
force-pushed
the
fix_missing_hash_url_sync
branch
from
9feebfe
to
6a6828a
Compare
lgestc
force-pushed
the
fix_missing_hash_url_sync
branch
from
6a6828a
to
5352b0f
Compare
lgestc
force-pushed
the
fix_missing_hash_url_sync
branch
from
080d931
to
557a5cb
Compare
lgestc
added
the
Team:Threat Hunting:Investigations
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
PhilippeOberti
approved these changes
Sep 21, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 22, 2023
## Summary This PR fixes the root cause for elastic#166686 and elastic#166774 @angorayc @machadoum ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit d52c5a1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 29, 2023
…167010) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Fix missing hash in sync to url (#166847)](#166847) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Luke G","email":"11671118+lgestc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-09-22T08:23:50Z","message":"[Security Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.11.0","v8.10.2"],"number":166847,"url":"#166847 Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"#166847 Solution] Fix missing hash in sync to url (#166847)\n\n## Summary\r\n\r\nThis PR fixes the root cause for\r\nhttps://github.com//issues/166686 and\r\nhttps://github.com//issues/166774\r\n\r\n@angorayc @machadoum \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"d52c5a15fdd9e3c8502fbb75378295c5c7649cc6"}},{"branch":"8.10","label":"v8.10.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Luke G <11671118+lgestc@users.noreply.github.com>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the root cause for #166686 and #166774
@angorayc @machadoum
Checklist
Delete any items that are not applicable to this PR.