[ML] AIOps: Fixes render loop when using a saved search. #166934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
walterra
requested review from
alvarezmelissa87,
peteharverson and
jgowdyelastic
|
Pinging @elastic/ml-ui (:ml) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @walterra |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 21, 2023
## Summary Fixes elastic#166079. If a user picked a saved search to investigate, the log pattern analysis page would freeze with an infinite render loop; the log rate analysis pate wouldn't freeze but repeatedly query for new data. This PR fixes the issue by memoizing the queries derived from the saved search information to avoid it being a new instance every time. ### Checklist - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit fabaa2f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 25, 2023
…#166956) # Backport This will backport the following commits from `main` to `8.10`: - [[ML] AIOps: Fix render loop when using saved search. (#166934)](#166934) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"walter.rafelsberger@elastic.co"},"sourceCommit":{"committedDate":"2023-09-21T15:28:38Z","message":"[ML] AIOps: Fix render loop when using saved search. (#166934)\n\n## Summary\r\n\r\nFixes #166079.\r\n\r\nIf a user picked a saved search to investigate, the log pattern analysis\r\npage would freeze with an infinite render loop; the log rate analysis\r\npate wouldn't freeze but repeatedly query for new data.\r\n\r\nThis PR fixes the issue by memoizing the queries derived from the saved\r\nsearch information to avoid it being a new instance every time.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"fabaa2f89ecc7737b744b1a352251dc654d564a8","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:ML/AIOps","v8.11.0","v8.10.3"],"number":166934,"url":"https://github.com/elastic/kibana/pull/166934","mergeCommit":{"message":"[ML] AIOps: Fix render loop when using saved search. (#166934)\n\n## Summary\r\n\r\nFixes #166079.\r\n\r\nIf a user picked a saved search to investigate, the log pattern analysis\r\npage would freeze with an infinite render loop; the log rate analysis\r\npate wouldn't freeze but repeatedly query for new data.\r\n\r\nThis PR fixes the issue by memoizing the queries derived from the saved\r\nsearch information to avoid it being a new instance every time.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"fabaa2f89ecc7737b744b1a352251dc654d564a8"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166934","number":166934,"mergeCommit":{"message":"[ML] AIOps: Fix render loop when using saved search. (#166934)\n\n## Summary\r\n\r\nFixes #166079.\r\n\r\nIf a user picked a saved search to investigate, the log pattern analysis\r\npage would freeze with an infinite render loop; the log rate analysis\r\npate wouldn't freeze but repeatedly query for new data.\r\n\r\nThis PR fixes the issue by memoizing the queries derived from the saved\r\nsearch information to avoid it being a new instance every time.\r\n\r\n### Checklist\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"fabaa2f89ecc7737b744b1a352251dc654d564a8"}},{"branch":"8.10","label":"v8.10.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Walter Rafelsberger <walter.rafelsberger@elastic.co>
peteharverson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #166079.
If a user picked a saved search to investigate, the log pattern analysis page would freeze with an infinite render loop; the log rate analysis pate wouldn't freeze but repeatedly query for new data.
This PR fixes the issue by memoizing the queries derived from the saved search information to avoid it being a new instance every time.
Checklist