Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Errors rules link on observability alert page #167027

Merged

Conversation

maryam-saeidi
Copy link
Member

@maryam-saeidi maryam-saeidi commented Sep 22, 2023

Fixes #167004

Summary

This PR fixes the Errors stat link and improves the code using the Rules locator.

image

🧪 How to test

  • Please check all the statuses (Disabled, Snoozed, Errors) to make sure links work as expected.

@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience release_note:fix backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 22, 2023
@maryam-saeidi maryam-saeidi self-assigned this Sep 22, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.0MB 1.0MB +56.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

@maryam-saeidi maryam-saeidi marked this pull request as ready for review September 22, 2023 14:25
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner September 22, 2023 14:25
@fkanout fkanout self-requested a review September 25, 2023 12:35
Copy link
Contributor

@fkanout fkanout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it counts the rules correctly and navigate with correct params when a state is clicked.
Screenshot 2023-09-25 at 14 41 13

@maryam-saeidi maryam-saeidi merged commit 258e984 into elastic:main Sep 25, 2023
20 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.10 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 167027

Questions ?

Please refer to the Backport tool documentation

@maryam-saeidi maryam-saeidi added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 25, 2023
@maryam-saeidi maryam-saeidi deleted the 167004-fix-failed-rules-link branch September 25, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:fix v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failed rules link on observability alert page
5 participants