[APM] Add time range to event metadata API #167132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:APM) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
gbamparop
reviewed
Sep 25, 2023
sorenlouv
force-pushed
the
add-time-range-event-metadata-api
branch
from
3045014
to
8138fb2
Compare
sorenlouv
force-pushed
the
add-time-range-event-metadata-api
branch
from
8138fb2
to
be998ab
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
| // @ts-expect-error | ||
| id: doc[processorEvent].id as string, | ||
| timestamp: doc['@timestamp'], | ||
| }; | ||
| } | ||
|
|
||
| registry.when('Event metadata', { config: 'basic', archives: ['apm_8.0.0'] }, () => { |
There was a problem hiding this comment.
nit: We will have to start adhering to the new API guidelines, which Dario is creating where if someone works on an API test which use Archives, then we should migrate it to Synthtrace or Index using ES. This way we will soon get rid of all Archives without spending dedicate time.
There was a problem hiding this comment.
That's a good point. I'll convert this asap
achyutjhunjhunwala
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166424