Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Transforms] Fixing use full data button #167404

Merged
merged 4 commits into from
Sep 28, 2023
Merged

[Transforms] Fixing use full data button #167404

merged 4 commits into from
Sep 28, 2023

Conversation

jgowdyelastic
Copy link
Member

Fixing bug introduced by a merge clash between #166622 and #166651

The hideFrozenDataTierChoice prop is no longer available in the FullTimeRangeSelector component and so the transforms plugin needs to set showFrozenDataTierChoice in the data picker context.

@jgowdyelastic jgowdyelastic added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v8.11.0 Serverless labels Sep 27, 2023
@jgowdyelastic jgowdyelastic self-assigned this Sep 27, 2023
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner September 27, 2023 12:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic mentioned this pull request Sep 27, 2023
Merged
@maryam-saeidi maryam-saeidi mentioned this pull request Sep 27, 2023
Merged
@qn895
Copy link
Member

qn895 commented Sep 27, 2023

Tested and LGTM 🎉

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #16 / serverless examples UI Partial Results Example "before all" hook for "should trace mouse events"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 594.0KB 594.1KB +153.0B
dataVisualizer 613.3KB 613.4KB +153.0B
ml 3.5MB 3.5MB +153.0B
transform 400.8KB 401.2KB +380.0B
total +839.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 046718c into elastic:main Sep 28, 2023
21 checks passed
@jgowdyelastic jgowdyelastic deleted the fixing-transforms-use-full-data-button branch September 28, 2023 10:09
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 28, 2023
@watson watson added the Project:Serverless Work as part of the Serverless project for its initial release label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting Feature:Transforms ML transforms :ml Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jgowdyelastic @elasticmachine @qn895 @kibana-ci @watson @kibanamachine