[infra] Use correct ML API to query blocking tasks #167779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miltonhultgren
added
release_note:fix
Feature:Logs UI
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
miltonhultgren
commented
Oct 2, 2023
Comment on lines
+126
to
+128
| onReject: (e) => { | ||
| throw new Error(`Failed to clean up previous ML job: ${e}`); | ||
| }, |
There was a problem hiding this comment.
This part was weird, if I don't do this, then the Promise is not rejected even if the API call throws an error (which is why we didn't see this API move).
@weltenwort Do you know if that's expected?
There was a problem hiding this comment.
My guess is that useTrackedPromise is swallowing errors and expecting callers to look for and respond to the "rejected" state instead, https://github.com/miltonhultgren/kibana/blob/d91fe9fc92133cfa52c4b9aff664018b241f2ac3/x-pack/plugins/infra/public/utils/use_tracked_promise.ts#L222
There was a problem hiding this comment.
Not sure which makes more sense here exactly, but you could look at cleanUpModuleRequest.state for "rejected" and respond, rather than throwing this new error?
There was a problem hiding this comment.
I'm throwing here because this function is called further down and then as a Promise with a catch to update the reducer state, if I don't catch I'm outside of that flow and the setup call is done ahead of time which causes an inconsistent state.
klacabane
reviewed
Oct 4, 2023
x-pack/plugins/infra/public/containers/logs/log_analysis/log_analysis_cleanup.tsx
Show resolved
Hide resolved
klacabane
approved these changes
Oct 4, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2023
While working on elastic#47477, I found that attempting to re-create a ML job faces a 404 because it uses an endpoint that has been removed / changed. This PR updates to use the newer endpoint to find which tasks are blocking in the ML system (like job deletion) and changes the types to match the new API. (cherry picked from commit 48b66d7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2023
…168075) # Backport This will backport the following commits from `main` to `8.11`: - [[infra] Use correct ML API to query blocking tasks (#167779)](#167779) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Milton Hultgren","email":"milton.hultgren@elastic.co"},"sourceCommit":{"committedDate":"2023-10-05T09:39:23Z","message":"[infra] Use correct ML API to query blocking tasks (#167779)\n\nWhile working on #47477, I found\r\nthat attempting to re-create a ML job faces a 404 because it uses an\r\nendpoint that has been removed / changed.\r\n\r\nThis PR updates to use the newer endpoint to find which tasks are\r\nblocking in the ML system (like job deletion) and changes the types to\r\nmatch the new API.","sha":"48b66d72dc8fc40fdf21a8c812cfd7659686ccf2","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Logs UI","Team:Infra Monitoring UI","backport:prev-minor","v8.12.0"],"number":167779,"url":"#167779 Use correct ML API to query blocking tasks (#167779)\n\nWhile working on #47477, I found\r\nthat attempting to re-create a ML job faces a 404 because it uses an\r\nendpoint that has been removed / changed.\r\n\r\nThis PR updates to use the newer endpoint to find which tasks are\r\nblocking in the ML system (like job deletion) and changes the types to\r\nmatch the new API.","sha":"48b66d72dc8fc40fdf21a8c812cfd7659686ccf2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"#167779 Use correct ML API to query blocking tasks (#167779)\n\nWhile working on #47477, I found\r\nthat attempting to re-create a ML job faces a 404 because it uses an\r\nendpoint that has been removed / changed.\r\n\r\nThis PR updates to use the newer endpoint to find which tasks are\r\nblocking in the ML system (like job deletion) and changes the types to\r\nmatch the new API.","sha":"48b66d72dc8fc40fdf21a8c812cfd7659686ccf2"}}]}] BACKPORT--> Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
While working on elastic#47477, I found that attempting to re-create a ML job faces a 404 because it uses an endpoint that has been removed / changed. This PR updates to use the newer endpoint to find which tasks are blocking in the ML system (like job deletion) and changes the types to match the new API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #47477, I found that attempting to re-create a ML job faces a 404 because it uses an endpoint that has been removed / changed.
This PR updates to use the newer endpoint to find which tasks are blocking in the ML system (like job deletion) and changes the types to match the new API.