Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add functional tests for Data Drift view #167911

Merged
merged 17 commits into from
Oct 12, 2023
Merged

[ML] Add functional tests for Data Drift view #167911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d441274
Add tests
qn895 Oct 3, 2023
90a6a7a
Fix test data type
qn895 Oct 3, 2023
6644959
Merge remote-tracking branch 'upstream/main' into ml-data-drift-func-…
qn895 Oct 4, 2023
7e99182
Assert time field
qn895 Oct 5, 2023
687a8ea
Merge remote-tracking branch 'upstream/main' into ml-data-drift-func-…
qn895 Oct 5, 2023
92494a2
Assert tests for data drift from trained model page
qn895 Oct 6, 2023
d7b5906
Assert tests for data drift from trained model page
qn895 Oct 6, 2023
9460e16
Revert input to append wildcard
qn895 Oct 6, 2023
f7b86cb
Stabilize tests
qn895 Oct 6, 2023
f2237b6
Fix //
qn895 Oct 10, 2023
5a9f89a
Hide NaN
qn895 Oct 10, 2023
6f0bde3
Merge remote-tracking branch 'upstream/main' into ml-data-drift-func-…
qn895 Oct 10, 2023
e7d668b
Merge remote-tracking branch 'upstream/main' into ml-data-drift-func-…
qn895 Oct 11, 2023
820da05
Update NaN
qn895 Oct 11, 2023
0ef6b56
Fix disabled state
qn895 Oct 11, 2023
f180ede
Merge branch 'main' into ml-data-drift-func-tests
kibanamachine Oct 12, 2023
5a4a6d4
Merge branch 'main' into ml-data-drift-func-tests
kibanamachine Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_overview_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@ export const DataDriftOverviewTable = ({

return (
<EuiButtonIcon
data-test-subj={`dataDriftToggleDetails-${
itemIdToExpandedRowMapValues[item.featureName] ? 'expanded' : 'collapsed'
}`}
onClick={() => toggleDetails(item)}
aria-label={itemIdToExpandedRowMapValues[item.featureName] ? COLLAPSE_ROW : EXPAND_ROW}
iconType={itemIdToExpandedRowMapValues[item.featureName] ? 'arrowDown' : 'arrowRight'}
Expand Down Expand Up @@ -149,7 +152,10 @@ export const DataDriftOverviewTable = ({
'data-test-subj': 'mlDataDriftOverviewTableDriftDetected',
sortable: true,
textOnly: true,
render: (driftDetected: boolean) => {
render: (driftDetected: boolean, item) => {
// @ts-expect-error currently ES two_sided does return string NaN, will be fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an issue we can mention in the comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valeriy is investigating this and will create an issue on the Elasticsearch side. But for now, we don't have an issue.

// NaN happens when the distributions are non overlapping. This means there is a drift.
if (item.similarityTestPValue === 'NaN') return dataComparisonYesLabel;
return <span>{driftDetected ? dataComparisonYesLabel : dataComparisonNoLabel}</span>;
},
},
Expand Down
6 changes: 5 additions & 1 deletion x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,11 @@ export const PageHeader: FC = () => {

return (
<EuiPageHeader
pageTitle={<div css={dataViewTitleHeader}>{dataView.getName()}</div>}
pageTitle={
<div data-test-subj={'mlDataDriftPageDataViewTitle'} css={dataViewTitleHeader}>
{dataView.getName()}
</div>
}
rightSideItems={[
<EuiFlexGroup gutterSize="s" data-test-subj="dataComparisonTimeRangeSelectorSection">
{hasValidTimeField ? (
Expand Down
5 changes: 4 additions & 1 deletion x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@
* formatSignificanceLevel
* @param significanceLevel
*/
export const formatSignificanceLevel = (significanceLevel: number) => {
export const formatSignificanceLevel = (significanceLevel: number | 'NaN') => {
// NaN happens when the distributions are non overlapping. This means there is a drift, and the p-value would be astronomically small.
if (significanceLevel === 'NaN') return '< 0.000001';
if (typeof significanceLevel !== 'number' || isNaN(significanceLevel)) return '';

if (significanceLevel < 1e-6) {
return '< 0.000001';
} else if (significanceLevel < 0.01) {
Expand Down
4 changes: 2 additions & 2 deletions .../plugins/data_visualizer/public/application/data_drift/document_count_with_dual_brush.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export const DocumentCountWithDualBrush: FC<DocumentCountContentProps> = ({
timeRangeEarliest === undefined ||
timeRangeLatest === undefined
) {
return totalCount !== undefined ? <TotalCountHeader totalCount={totalCount} /> : null;
return totalCount !== undefined ? <TotalCountHeader totalCount={totalCount} id={id} /> : null;
}

const chartPoints: LogRateHistogramItem[] = Object.entries(documentCountStats.buckets).map(
Expand All @@ -166,7 +166,7 @@ export const DocumentCountWithDualBrush: FC<DocumentCountContentProps> = ({
data-test-subj={getDataTestSubject('dataDriftTotalDocCountHeader', id)}
>
<EuiFlexItem>
<TotalCountHeader totalCount={totalCount} approximate={approximate} label={label} />
<TotalCountHeader totalCount={totalCount} approximate={approximate} label={label} id={id} />
</EuiFlexItem>

<EuiFlexGroup gutterSize="m" direction="row" alignItems="center">
Expand Down
8 changes: 4 additions & 4 deletions ...gins/ml/public/application/datavisualizer/data_drift/data_drift_index_patterns_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export function DataDriftIndexPatternsEditor({
children: (
<EuiFlexItem grow={false}>
<DataViewEditor
key={'reference'}
id={'reference'}
label={
<FormattedMessage
id="xpack.ml.dataDrift.indexPatternsEditor.referenceData"
Expand Down Expand Up @@ -274,7 +274,7 @@ export function DataDriftIndexPatternsEditor({
children: (
<EuiFlexItem grow={false}>
<DataViewEditor
key={'comparison'}
id={'comparison'}
label={
<FormattedMessage
id="xpack.ml.dataDrift.indexPatternsEditor.comparisonDataIndexPatternHelp"
Expand Down Expand Up @@ -329,7 +329,7 @@ export function DataDriftIndexPatternsEditor({
}}
isClearable={false}
isDisabled={comparisonIndexPattern === '' && referenceIndexPattern === ''}
data-test-subj="timestampField"
data-test-subj="mlDataDriftTimestampField"
aria-label={i18n.translate(
'xpack.ml.dataDrift.indexPatternsEditor.timestampSelectAriaLabel',
{
Expand Down Expand Up @@ -389,7 +389,7 @@ export function DataDriftIndexPatternsEditor({
disabled={hasError}
onClick={createDataViewAndRedirectToDataDriftPage.bind(null, true)}
iconType="visTagCloud"
data-test-subj="analyzeDataDriftButton"
data-test-subj="analyzeDataDriftWithoutSavingButton"
aria-label={i18n.translate(
'xpack.ml.dataDrift.indexPatternsEditor.analyzeDataDriftWithoutSavingLabel',
{
Expand Down
11 changes: 10 additions & 1 deletion x-pack/plugins/ml/public/application/datavisualizer/data_drift/data_view_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import { useTableSettings } from '../../data_frame_analytics/pages/analytics_man
import { canAppendWildcard, matchedIndicesDefault } from './data_drift_index_patterns_editor';

interface DataViewEditorProps {
id: string;
label: ReactNode;
dataViewEditorService: DataViewEditorService;
indexPattern: string;
Expand All @@ -42,6 +43,7 @@ const mustMatchError = i18n.translate(
);

export function DataViewEditor({
id,
label,
dataViewEditorService,
indexPattern,
Expand Down Expand Up @@ -131,6 +133,7 @@ export function DataViewEditor({
isInvalid={errorMessage !== undefined}
fullWidth
helpText={helpText}
data-test-subj={`mlDataDriftIndexPatternFormRow-${id ?? ''}`}
>
<EuiFieldText
value={indexPattern}
Expand All @@ -149,7 +152,7 @@ export function DataViewEditor({
setIndexPattern(query);
}}
fullWidth
data-test-subj="createIndexPatternTitleInput"
data-test-subj={`mlDataDriftIndexPatternTitleInput-${id ?? ''}`}
placeholder="example-pattern*"
/>
</EuiFormRow>
Expand Down Expand Up @@ -183,6 +186,12 @@ export function DataViewEditor({
columns={columns}
pagination={pagination}
onChange={onTableChange}
data-test-subject={`mlDataDriftIndexPatternTable-${id ?? ''}`}
rowProps={(item) => {
return {
'data-test-subj': `mlDataDriftIndexPatternTableRow row-${id}`,
};
}}
/>
</EuiFlexItem>
</EuiFlexGrid>
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/ml/public/application/datavisualizer/data_drift/index_patterns_picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ export const DataDriftIndexOrSearchRedirect: FC = () => {
iconType="plusInCircleFilled"
onClick={() => navigateToPath(createPath(ML_PAGES.DATA_DRIFT_CUSTOM))}
disabled={!canEditDataView}
data-test-subj={'dataDriftCreateDataViewButton'}
>
<FormattedMessage
id="xpack.ml.dataDrift.createDataViewButton"
Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/ml/public/application/model_management/expanded_row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,15 +429,15 @@ export const ExpandedRow: FC<ExpandedRowProps> = ({ item }) => {
: []),
{
id: 'models_map',
'data-test-subj': 'mlTrainedModelsMap',
'data-test-subj': 'mlTrainedModelMap',
name: (
<FormattedMessage
id="xpack.ml.trainedModels.modelsList.expandedRow.modelsMapLabel"
defaultMessage="Models map"
/>
),
content: (
<div data-test-subj={'mlTrainedModelDetailsContent'}>
<div data-test-subj={'mlTrainedModelMapContent'}>
<EuiSpacer size={'s'} />
<EuiFlexItem css={{ height: 300 }}>
<JobMap
Expand Down
Loading
Loading