[ML] Fixes anomaly charts when partition field contains an empty string #168102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
|
Tested and LGTM 🎉 |
qn895
approved these changes
Oct 5, 2023
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @darnautov |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2023
…elastic#168102) ## Summary Fixes elastic#168067. Fixes anomaly charts fetching by replacing logical OR operator with nullish coalescing.  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit efa4e76)
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2023
… string (#168102) (#168180) # Backport This will backport the following commits from `main` to `8.11`: - [[ML] Fix anomaly charts when partition field contains an empty string (#168102)](#168102) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-10-06T07:49:25Z","message":"[ML] Fix anomaly charts when partition field contains an empty string (#168102)\n\n## Summary\r\n\r\nFixes #168067.\r\n\r\nFixes anomaly charts fetching by replacing logical OR operator with\r\nnullish coalescing.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"efa4e76203a1c20977994559b0e57c09d7751310","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:Anomaly Detection","Team:ML","v8.11.0","v8.12.0"],"number":168102,"url":"#168102 Fix anomaly charts when partition field contains an empty string (#168102)\n\n## Summary\r\n\r\nFixes #168067.\r\n\r\nFixes anomaly charts fetching by replacing logical OR operator with\r\nnullish coalescing.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"efa4e76203a1c20977994559b0e57c09d7751310"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"#168102 Fix anomaly charts when partition field contains an empty string (#168102)\n\n## Summary\r\n\r\nFixes #168067.\r\n\r\nFixes anomaly charts fetching by replacing logical OR operator with\r\nnullish coalescing.\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"efa4e76203a1c20977994559b0e57c09d7751310"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
szabosteve
changed the title
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
…elastic#168102) ## Summary Fixes elastic#168067. Fixes anomaly charts fetching by replacing logical OR operator with nullish coalescing.  ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #168067.
Fixes anomaly charts fetching by replacing logical OR operator with nullish coalescing.
Checklist