Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] API integration tests for start and stop model deployment #168460

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Oct 10, 2023

Summary

Part of #164562

Adds API integration tests for _start and _stop trained model deployment.

Checklist

@darnautov darnautov added :ml release_note:skip Skip the PR/issue when compiling release notes test-api-integration Team:ML Team label for ML (also use :ml) v8.11.0 v8.12.0 labels Oct 10, 2023
@darnautov darnautov self-assigned this Oct 10, 2023
@darnautov darnautov requested a review from a team as a code owner October 10, 2023 12:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov enabled auto-merge (squash) October 10, 2023 14:55
@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@darnautov darnautov merged commit 9ba0e71 into elastic:main Oct 10, 2023
32 of 33 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #49 / serverless security UI Case View customFields updates a custom field correctly

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2023
…ic#168460)

## Summary

Part of elastic#164562

Adds API integration tests for `_start` and `_stop` trained model
deployment.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 9ba0e71)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@darnautov darnautov deleted the ml-164562-api-tests branch October 10, 2023 17:11
kibanamachine added a commit that referenced this pull request Oct 10, 2023
…#168460) (#168513)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[ML] API integration tests for start and stop model deployment
(#168460)](#168460)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-10-10T16:59:33Z","message":"[ML]
API integration tests for start and stop model deployment
(#168460)\n\n## Summary\r\n\r\nPart of #164562\r\n\r\nAdds API
integration tests for `_start` and `_stop` trained
model\r\ndeployment.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9ba0e710a545ae3bb6f54303a5989619ea8f64ee","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","test-api-integration","Team:ML","v8.11.0","v8.12.0"],"number":168460,"url":"#168460
API integration tests for start and stop model deployment
(#168460)\n\n## Summary\r\n\r\nPart of #164562\r\n\r\nAdds API
integration tests for `_start` and `_stop` trained
model\r\ndeployment.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9ba0e710a545ae3bb6f54303a5989619ea8f64ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"#168460
API integration tests for start and stop model deployment
(#168460)\n\n## Summary\r\n\r\nPart of #164562\r\n\r\nAdds API
integration tests for `_start` and `_stop` trained
model\r\ndeployment.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9ba0e710a545ae3bb6f54303a5989619ea8f64ee"}}]}]
BACKPORT-->

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
…ic#168460)

## Summary

Part of elastic#164562

Adds API integration tests for `_start` and `_stop` trained model
deployment.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test-api-integration v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants