[Cases] Wait for the configuration page to appear before starting the tests #168465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
|
@elasticmachine merge upstream |
pheyos
reviewed
Oct 11, 2023
x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts
Show resolved
Hide resolved
cnasikas
changed the title
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
|
@elasticmachine merge upstream |
adcoelho
reviewed
Oct 13, 2023
| @@ -26,8 +26,18 @@ export default ({ getPageObject, getService }: FtrProviderContext) => { | |||
| await svlCommonPage.login(); | |||
| await svlSecNavigation.navigateToLandingPage(); | |||
| await testSubjects.click('solutionSideNavItemLink-cases'); | |||
| await header.waitUntilLoadingHasFinished(); | |||
|
|
|||
| await retry.waitFor('configure-case-button exist', async () => { | |||
There was a problem hiding this comment.
maybe I'm confused but isn't this the same as
await retry.waitFor('configure-case-button exist', testSubjects.exists('configure-case-button'));
?
There was a problem hiding this comment.
Probably yes 🙂. I never thought about it tbh. I will keep it in mind for the next time. Thanks!
adcoelho
approved these changes
Oct 13, 2023
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
… tests (elastic#168465) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Oct 22, 2023
… tests (elastic#168465) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Oct 22, 2023
… tests (elastic#168465) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR intends (I hope for the last time 😄 ) to fix the tests on the configuration page. Seldomly, the navigation is not complete, and the tests start running before navigating to the configuration page.
Fixes: #166469, #167869
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3463, https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3484, https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3496
Checklist
Delete any items that are not applicable to this PR.
For maintainers