[Cases] Unskip MKI tests #168924
Merged
[Cases] Unskip MKI tests #168924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
cnasikas
commented
Oct 16, 2023
| await retry.waitFor('update toast exist', async () => { | ||
| return await testSubjects.exists('toastCloseButton'); | ||
| }); | ||
|
|
||
| await testSubjects.click('toastCloseButton'); | ||
|
|
||
| await sync.click(); | ||
| await header.waitUntilLoadingHasFinished(); |
There was a problem hiding this comment.
We need to wait here for the case to be refreshed. Otherwise we get an 403 conflict error because the test is too fast.
cnasikas
commented
Oct 16, 2023
| await dashboard.waitForRenderComplete(); | ||
| }); | ||
|
|
||
| after(async () => { | ||
| await cases.api.deleteAllCases(); | ||
| await svlCases.api.deleteAllCaseItems(); |
There was a problem hiding this comment.
Needed to avoid permission errors when deleting directly a document from the .kibana_alerting_cases system index.
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
adcoelho
approved these changes
Oct 16, 2023
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
1 task
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @cnasikas |
pheyos
approved these changes
Oct 23, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Oct 24, 2023
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 2146a7e) # Conflicts: # x-pack/test_serverless/functional/test_suites/observability/cases/attachment_framework.ts # x-pack/test_serverless/functional/test_suites/observability/cases/list_view.ts # x-pack/test_serverless/functional/test_suites/observability/cases/view_case.ts # x-pack/test_serverless/functional/test_suites/security/ftr/cases/list_view.ts # x-pack/test_serverless/functional/test_suites/security/ftr/cases/view_case.ts # x-pack/test_serverless/functional/test_suites/security/index.ts
cnasikas
added a commit
that referenced
this pull request
Oct 24, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [[Cases] Unskip MKI tests (#168924)](#168924) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Christos Nasikas","email":"christos.nasikas@elastic.co"},"sourceCommit":{"committedDate":"2023-10-23T09:21:25Z","message":"[Cases] Unskip MKI tests (#168924)\n\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"2146a7ef1634a06cf6b4b70edc55dd22fd5b6a4c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:ResponseOps","Feature:Cases","ci:skip-cypress-osquery","v8.11.0","v8.12.0"],"number":168924,"url":"#168924 Unskip MKI tests (#168924)\n\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"2146a7ef1634a06cf6b4b70edc55dd22fd5b6a4c"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"#168924 Unskip MKI tests (#168924)\n\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"2146a7ef1634a06cf6b4b70edc55dd22fd5b6a4c"}}]}] BACKPORT-->
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR unskips all Cases' serverless tests for MKI. I run all tests without any issues to a Serverless instance deployed on the cloud.
Notable changes:
deleteAllCaseItemsfrom the Serverless API service and not the ESS API service. Not using the Serverless API service was causing issues when trying to delete documents from the.kibana_alerting_casessystem index.Fixes: #165135, #168534, #169005
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3579, https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3639
Checklist
Delete any items that are not applicable to this PR.
For maintainers