[APM] Mobile most launches #168925

LikeTheSalad · 2023-10-16T08:50:29Z

Summary

Enabling the "Most launches" Mobile dashboard panel which shows an aggregation of log events that contain the attribute labels.lifecycle_state set to either created (for Android) or active (for iOS).

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2023-10-16T08:50:36Z

Pinging @elastic/apm-ui (Team:APM)

apmmachine · 2023-10-16T08:50:48Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

CoenWarmer

AO changes LGTM

LikeTheSalad · 2023-10-16T08:52:37Z

@elasticmachine merge upstream

… mobile-launches

This reverts commit 5c8b70b.

LikeTheSalad · 2023-10-18T10:01:39Z

@elasticmachine merge upstream

… mobile-launches

kpatticha · 2023-10-27T11:57:15Z

x-pack/plugins/apm/typings/es_schemas/raw/event_raw.ts

+}
+
+export interface EventRaw extends APMBaseDoc {
+  processor: Processor;


Does the EventRaw have the processor field?

Good point, it doesn't. I'll remove it

It's updated now!

kpatticha · 2023-10-27T12:02:15Z

x-pack/plugins/apm/server/routes/mobile/get_mobile_launches_by_location.ts

+  const aggs = {
+    launches: {
+      filter: {
+        terms: { ['labels.lifecycle_state']: ['created', 'active'] },


nit: Can you please convert labels.lifecycle_state as constant. Similar https://github.com/LikeTheSalad/kibana/blob/3a48bc9289b7dc9b8ecdebbf224a55686a5078f1/x-pack/plugins/apm/common/es_fields/apm.ts#L192C1-L192C1

Also, the values created and active can be enum.

I've converted labels.lifecycle_state to constant 👍 However, regarding creating enums for created and active, I'm not sure what could be a proper file to place them? Also, I guess we'd have to create 2 separate enums, one for android events which would contain created and other for iOS's events with active?

x-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts

packages/kbn-apm-synthtrace-client/src/lib/apm/event.ts

LikeTheSalad · 2023-10-30T08:33:57Z

@elasticmachine merge upstream

kpatticha

Great job, @LikeTheSalad! Thank you for your efforts.

I couldn't test the Android due to the lack of data in edge. I did review the iOS launches, and they seem great, except for the time series. I left a comment with my feedback.

kpatticha · 2023-11-01T08:37:01Z

x-pack/plugins/apm/server/routes/mobile/get_mobile_launches_by_location.ts

+      response.aggregations?.timeseries?.buckets.map((bucket) => ({
+        x: bucket.key,
+        y:
+          response.aggregations?.launches?.byLocation?.buckets[0]?.doc_count ??


Suggested change

response.aggregations?.launches?.byLocation?.buckets[0]?.doc_count ??

bucket.launches?.byLocation?.buckets[0]?.doc_count ?? 0

Otherwise, you'll always return the total launches for the timeseries.
it seems we have introduced this bug here

kibana/x-pack/plugins/apm/server/routes/mobile/get_mobile_http_requests_by_location.ts

Line 115 in 1697bbb

response.aggregations?.requests?.requestsByLocation?.buckets[0]

can you please fix there as well 🙏

Could you also please add an API test to prevent this issue? It appears that our existing tests were insufficient in identifying this problem

Hi @kpatticha - I've just made these changes, fixed the same issue for get_mobile_http_requests_by_location.ts and also I had to fix it in here as well:

kibana/x-pack/plugins/apm/server/routes/mobile/get_mobile_crashes_by_location.ts

Line 105 in 1697bbb

response.aggregations?.crashes?.crashesByLocation?.buckets[0]

I've also updated the API test to verify the changes. It should be good now, cheers!

x-pack/plugins/apm/server/routes/mobile/get_mobile_launches_by_location.ts

…_location.ts Co-authored-by: Katerina <kate@kpatticha.com>

LikeTheSalad · 2023-11-03T10:49:14Z

@elasticmachine merge upstream

x-pack/test/apm_api_integration/tests/mobile/mobile_location_stats.spec.ts

LikeTheSalad · 2023-11-06T11:31:25Z

@elasticmachine merge upstream

kibana-ci · 2023-11-06T12:49:00Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 9749e39

Failed CI Steps

Test Failures

[job] [logs] Serverless Osquery Cypress Tests #4 / ALL - Live Query should run multiline query should run multiline query
[job] [logs] Investigations - Security Solution Cypress Tests #4 / Save Timeline Prompts "before each" hook for "When user navigates to the page where timeline is present, Time save modal should not exists." "before each" hook for "When user navigates to the page where timeline is present, Time save modal should not exists."

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/apm-synthtrace-client`	180	181	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	3.7MB	3.7MB	+142.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/apm-synthtrace-client`	26	27	+1

Unknown metric groups

API count

id	before	after	diff
`@kbn/apm-synthtrace-client`	180	181	+1

History

💚 Build #173120 succeeded fe3df19
💔 Build #173093 failed 5cafe2f
💔 Build #173063 failed 8797da7
💔 Build #172809 failed 4516b20
💚 Build #171850 succeeded 1697bbb
💔 Build #171819 failed d1bbcfb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

LikeTheSalad added 10 commits October 11, 2023 11:18

Creating get mobile launches by location

ebc8f05

Adding most launches to location stats

e8fb0fe

Connecting most launches data to dashboard

cbcdff1

Created helper function to get log events

e67c0d0

Created helper function to get log events

2cb6a0d

Adding comment on reusing errors indices for events

f2acd01

Adding iOS active state for launches query

c4da8f4

Adding mobile launch tests

84fe444

Updating settins tests to add event index

700db7a

Removing event unused config index

5c8b70b

LikeTheSalad requested review from a team as code owners October 16, 2023 08:50

botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 16, 2023

LikeTheSalad requested a review from bryce-b October 16, 2023 08:50

LikeTheSalad requested a review from estolfo October 16, 2023 08:50

CoenWarmer approved these changes Oct 16, 2023

View reviewed changes

kibanamachine and others added 4 commits October 16, 2023 04:52

Merge branch 'main' into mobile-launches

4e9b616

Adding ApmFields

75f759e

Merge branch 'mobile-launches' of github.com:LikeTheSalad/kibana into…

ac0be49

… mobile-launches

Revert "Removing event unused config index"

8ed14d6

This reverts commit 5c8b70b.

Merge branch 'main' into mobile-launches

79e0a08

LikeTheSalad added the release_note:enhancement label Oct 18, 2023

LikeTheSalad added 4 commits October 18, 2023 12:47

Removing processorEvent.event

9fc934b

Adding event type response

5ac126e

Merge branch 'mobile-launches' of github.com:LikeTheSalad/kibana into…

d8b1777

… mobile-launches

Adding log event type to log event search response

61cbdbf

kpatticha reviewed Oct 27, 2023

View reviewed changes

x-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts Outdated Show resolved Hide resolved

kpatticha reviewed Oct 27, 2023

View reviewed changes

packages/kbn-apm-synthtrace-client/src/lib/apm/event.ts Outdated Show resolved Hide resolved

kibanamachine and others added 7 commits October 30, 2023 04:34

Merge branch 'main' into mobile-launches

5415f6f

Removing filter from APMEventClient.logEventSearch

50a5463

Removing processor from event_raw

894437f

Creating and using constant LABEL_LIFECYCLE_STATE

e17aca9

Properly handling test index routing in tests

faae624

Adding event.action to apm fields

d1bbcfb

Updating es fields snapshot

1697bbb

kpatticha approved these changes Nov 1, 2023

View reviewed changes

Update x-pack/plugins/apm/server/routes/mobile/get_mobile_launches_by…

4516b20

…_location.ts Co-authored-by: Katerina <kate@kpatticha.com>

kpatticha changed the title ~~Mobile most launches~~ [APM] Mobile most launches Nov 3, 2023

kibanamachine and others added 5 commits November 3, 2023 06:49

Merge branch 'main' into mobile-launches

8797da7

Fixing lambda param usage

7b0195f

Fixing mobile data by location timeseries and adding tests for it

1f794c9

Adding mobile location timeseries tests

5cafe2f

Addressing type errors for tests

fe3df19

kpatticha reviewed Nov 6, 2023

View reviewed changes

x-pack/test/apm_api_integration/tests/mobile/mobile_location_stats.spec.ts Outdated Show resolved Hide resolved

Enhancing api tests

4716f62

Merge branch 'main' into mobile-launches

9749e39

LikeTheSalad merged commit 820cfc0 into elastic:main Nov 6, 2023
32 checks passed

LikeTheSalad deleted the mobile-launches branch November 6, 2023 13:14

kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Mobile most launches #168925

[APM] Mobile most launches #168925

LikeTheSalad commented Oct 16, 2023 •

edited

Loading

elasticmachine commented Oct 16, 2023

apmmachine commented Oct 16, 2023

CoenWarmer left a comment

LikeTheSalad commented Oct 16, 2023

LikeTheSalad commented Oct 18, 2023

kpatticha Oct 27, 2023

LikeTheSalad Oct 27, 2023

LikeTheSalad Oct 30, 2023

kpatticha Oct 27, 2023

LikeTheSalad Oct 30, 2023

LikeTheSalad commented Oct 30, 2023

kpatticha left a comment

kpatticha Nov 1, 2023

kpatticha Nov 1, 2023

LikeTheSalad Nov 3, 2023 •

edited

Loading

LikeTheSalad commented Nov 3, 2023

LikeTheSalad commented Nov 6, 2023

kibana-ci commented Nov 6, 2023

API count

	response.aggregations?.launches?.byLocation?.buckets[0]?.doc_count ??
	bucket.launches?.byLocation?.buckets[0]?.doc_count ?? 0

[APM] Mobile most launches #168925

[APM] Mobile most launches #168925

Conversation

LikeTheSalad commented Oct 16, 2023 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Oct 16, 2023

apmmachine commented Oct 16, 2023

🤖 GitHub comments

CoenWarmer left a comment

Choose a reason for hiding this comment

LikeTheSalad commented Oct 16, 2023

LikeTheSalad commented Oct 18, 2023

kpatticha Oct 27, 2023

Choose a reason for hiding this comment

LikeTheSalad Oct 27, 2023

Choose a reason for hiding this comment

LikeTheSalad Oct 30, 2023

Choose a reason for hiding this comment

kpatticha Oct 27, 2023

Choose a reason for hiding this comment

LikeTheSalad Oct 30, 2023

Choose a reason for hiding this comment

LikeTheSalad commented Oct 30, 2023

kpatticha left a comment

Choose a reason for hiding this comment

kpatticha Nov 1, 2023

Choose a reason for hiding this comment

kpatticha Nov 1, 2023

Choose a reason for hiding this comment

LikeTheSalad Nov 3, 2023 • edited Loading

Choose a reason for hiding this comment

LikeTheSalad commented Nov 3, 2023

LikeTheSalad commented Nov 6, 2023

kibana-ci commented Nov 6, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

API count

History

LikeTheSalad commented Oct 16, 2023 •

edited

Loading

LikeTheSalad Nov 3, 2023 •

edited

Loading