[Discover] Address issue with defaultColumns when changing data views #168994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
Feature:Discover
jughosta
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jbudz
approved these changes
Nov 14, 2023
davismcphee
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Code changes look good, and I tested locally and ran the new functional tests and everything worked as expected according to #168581 👍 LGTM and thanks for fixing it!
jillguyonnet
pushed a commit
to jillguyonnet/kibana
that referenced
this pull request
Nov 16, 2023
…elastic#168994) - Closes elastic#168581 ## Summary This PR re-adds default columns when changing data views. Only columns which are present in the data view will be re-added. For testing: configure some fields for `defaultColumns` on Advanced Settings page and test switching data views on Discover page. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-adds default columns when changing data views. Only columns which are present in the data view will be re-added.
For testing: configure some fields for
defaultColumnson Advanced Settings page and test switching data views on Discover page.Checklist