Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Enable Serverless for entity_analytics Cypress tests #169209

Merged
merged 3 commits into from
Oct 24, 2023
Merged

[Security Solution] Enable Serverless for entity_analytics Cypress tests #169209

merged 3 commits into from
Oct 24, 2023

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Oct 18, 2023 •
edited

Summary

Running flaky test runner for x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics

Changes

  • x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts unskipped whole test suite in favour of failing test -> Custom Query rule - from legacy risk scores (see below) also enabled on Serverless
  • x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts enabled on Serverless

Related failing-test issues

  1. Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments·cy·ts - Enrichment Custom query rule from new risk scores Should has enrichment fields from legacy risk Should has enrichment fields from legacy risk #169154
    Marked as legit-flake and assigned to @elastic/security-detection-engine

Flaky test runner link

@jpdjere jpdjere requested a review from a team as a code owner October 18, 2023 08:51
@jpdjere jpdjere changed the title [Security Solution] Flaky test runner forentity_analytics Cypress tests [Security Solution] Flaky test runner for entity_analytics Cypress tests Oct 18, 2023
@jpdjere jpdjere marked this pull request as draft October 19, 2023 09:06
@jpdjere jpdjere mentioned this pull request Oct 19, 2023
Closed
@jpdjere jpdjere self-assigned this Oct 19, 2023
@jpdjere jpdjere mentioned this pull request Oct 19, 2023
Closed
@jpdjere jpdjere force-pushed the flaky-test-runner-entity_analytics branch from f1da44f to d11b66f Compare October 23, 2023 13:14
@jpdjere jpdjere force-pushed the flaky-test-runner-entity_analytics branch from 26f4e89 to 08b4c01 Compare October 23, 2023 16:19
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

@jpdjere jpdjere added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team:Detection Engine Security Solution Detection Engine Area v8.12.0 labels Oct 23, 2023
@jpdjere jpdjere marked this pull request as ready for review October 23, 2023 21:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@jpdjere jpdjere changed the title [Security Solution] Flaky test runner for entity_analytics Cypress tests [Security Solution] Enable Serverless for entity_analytics Cypress tests Oct 23, 2023
@yctercero
Copy link
Contributor

yctercero commented Oct 23, 2023 •
edited by rylnd

cc @rylnd @nkhristinin not sure if there's any work being done on these or if we're good to enable and merge.

@rylnd
Copy link
Contributor

rylnd commented Oct 24, 2023 •
edited

not sure if there's any work being done on these or if we're good to enable and merge

The test runner confirms #169154: there are some legitimate failures in those tests that need to be addressed. I can take a look tomorrow unless @nkhristinin would prefer to.

Edit: I see now that those flaky tests are still skipped in this PR. If the (main) build is green, I've got no objections to merging this!.

rylnd
rylnd approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests are still skipped, and that work is captured in #169154. LGTM!

@jpdjere jpdjere merged commit 12975a5 into elastic:main Oct 24, 2023
39 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 24, 2023
jpdjere added a commit to jpdjere/kibana that referenced this pull request Oct 24, 2023
@jpdjere
[Security Solution] Enable Serverless for entity_analytics Cypress …
b8e1c40 
…tests (elastic#169209)

Running flaky test runner for
`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics`

-
`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts`
**unskipped whole test suite in favour of failing test -> `Custom Query
rule - from legacy risk scores`** (see below) **also enabled on
Serverless**
-
`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts`
**enabled on Serverless**

1. elastic#169154
**Marked as legit-flake and assigned to
@elastic/security-detection-engine**

-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3575

(cherry picked from commit 12975a5)
@jpdjere jpdjere mentioned this pull request Oct 24, 2023
Merged
@jpdjere
Copy link
Contributor Author

jpdjere commented Oct 24, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jpdjere added a commit that referenced this pull request Oct 24, 2023
@jpdjere
[8.11] [Security Solution] Enable Serverless for entity_analytics C…
702e8b4 
…ypress tests (#169209) (#169682)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] Enable Serverless for `entity_analytics` Cypress
tests (#169209)](#169209)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Juan Pablo
Djeredjian","email":"jpdjeredjian@gmail.com"},"sourceCommit":{"committedDate":"2023-10-24T08:26:15Z","message":"[Security
Solution] Enable Serverless for `entity_analytics` Cypress tests
(#169209)\n\n## Summary\r\n\r\nRunning flaky test runner
for\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics`\r\n\r\n##
Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts`\r\n**unskipped
whole test suite in favour of failing test -> `Custom Query\r\nrule -
from legacy risk scores`** (see below) **also enabled
on\r\nServerless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts`\r\n**enabled
on Serverless**\r\n\r\n## Related failing-test issues\r\n\r\n1.
#169154 as
legit-flake and assigned
to\r\n@elastic/security-detection-engine**\r\n\r\n### Flaky test runner
link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3575","sha":"12975a5a0c6846d5cdbecc73beceba0346cd866b","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:Detections
and Resp","Team:Detection
Engine","v8.12.0"],"number":169209,"url":"#169209
Solution] Enable Serverless for `entity_analytics` Cypress tests
(#169209)\n\n## Summary\r\n\r\nRunning flaky test runner
for\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics`\r\n\r\n##
Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts`\r\n**unskipped
whole test suite in favour of failing test -> `Custom Query\r\nrule -
from legacy risk scores`** (see below) **also enabled
on\r\nServerless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts`\r\n**enabled
on Serverless**\r\n\r\n## Related failing-test issues\r\n\r\n1.
#169154 as
legit-flake and assigned
to\r\n@elastic/security-detection-engine**\r\n\r\n### Flaky test runner
link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3575","sha":"12975a5a0c6846d5cdbecc73beceba0346cd866b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"#169209
Solution] Enable Serverless for `entity_analytics` Cypress tests
(#169209)\n\n## Summary\r\n\r\nRunning flaky test runner
for\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics`\r\n\r\n##
Changes\r\n\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/enrichments.cy.ts`\r\n**unskipped
whole test suite in favour of failing test -> `Custom Query\r\nrule -
from legacy risk scores`** (see below) **also enabled
on\r\nServerless**\r\n-\r\n`x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_analytics_management_page.cy.ts`\r\n**enabled
on Serverless**\r\n\r\n## Related failing-test issues\r\n\r\n1.
#169154 as
legit-flake and assigned
to\r\n@elastic/security-detection-engine**\r\n\r\n### Flaky test runner
link\r\n\r\n-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3575","sha":"12975a5a0c6846d5cdbecc73beceba0346cd866b"}}]}]
BACKPORT-->
@jpdjere jpdjere mentioned this pull request Nov 6, 2023
Closed
@yctercero yctercero mentioned this pull request Nov 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

Assignees

@jpdjere jpdjere

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jpdjere @kibana-ci @elasticmachine @yctercero @rylnd @kibanamachine