-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Unskip tests for Detection Engine and Security Solution API Integration tests #169262
Merged
jpdjere
merged 3 commits into
elastic:main
from
jpdjere:flaky-test-integration-tests-security
Oct 31, 2023
Merged
[Security Solution] Unskip tests for Detection Engine and Security Solution API Integration tests #169262
jpdjere
merged 3 commits into
elastic:main
from
jpdjere:flaky-test-integration-tests-security
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2023
jpdjere
changed the title
[Security Solution] Flaky test runner for Detection Engine API Integration tests
[Security Solution] Flaky test runner for Detection Engine and Security Solution API Integration tests
Oct 19, 2023
This was referenced Oct 19, 2023
jpdjere
changed the title
[Security Solution] Flaky test runner for Detection Engine and Security Solution API Integration tests
[Security Solution] Unskip tests for Detection Engine and Security Solution API Integration tests
Oct 24, 2023
jpdjere
added
release_note:fix
Team:Detections and Resp
Security Detection Response Team
Team:Detection Engine
Security Solution Detection Engine Area
v8.11.0
v8.12.0
labels
Oct 24, 2023
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jpdjere |
yctercero
approved these changes
Oct 30, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2023
…lution API Integration tests (elastic#169262) ## Summary ### Changes - `x-pack/test/detection_engine_api_integration/security_and_spaces/group4/telemetry/task_based/detection_rules.ts` **unskipped** - `x-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/machine_learning.ts` **unskipped** ### Related flaky test issues **Tests already moved to `x-pack/test/security_solution_api_integration`** 1. elastic#169055 2. elastic#168775 This issue is reported for the legacy test, but is now moved to `x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/ips_text_array/text_array.ts` 3. elastic#163511 This issue is reported for the legacy test, but is now moved to `x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/keyword.ts` - Flaky test runner for above tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631 **Test still in `x-pack/test/detection_engine_api_integration`** 1. elastic#168415 2. elastic#164318 3. elastic#164313 4. elastic#145776 **Other** 1. elastic#151636 ## Flaky test runner link Part 1 - `x-pack/test/detection_engine_api_integration` - tests not yet migrated https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3597 Part 2 - `x-pack/test/security_solution_api_integration` - tests already moved https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631 (cherry picked from commit 9eff64a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jpdjere
added a commit
that referenced
this pull request
Oct 31, 2023
…rity Solution API Integration tests (#169262) (#170218) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] Unskip tests for Detection Engine and Security Solution API Integration tests (#169262)](#169262) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"jpdjeredjian@gmail.com"},"sourceCommit":{"committedDate":"2023-10-31T10:36:41Z","message":"[Security Solution] Unskip tests for Detection Engine and Security Solution API Integration tests (#169262)\n\n## Summary\r\n\r\n### Changes\r\n\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/group4/telemetry/task_based/detection_rules.ts`\r\n**unskipped**\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/machine_learning.ts`\r\n**unskipped**\r\n\r\n### Related flaky test issues\r\n\r\n**Tests already moved to\r\n`x-pack/test/security_solution_api_integration`**\r\n\r\n1. #169055. #168775 issue is reported for the legacy test, but is now moved to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/ips_text_array/text_array.ts`\r\n3. #163511 issue is reported for the legacy test, but is now moved to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/keyword.ts`\r\n\r\n- Flaky test runner for above tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631\r\n\r\n**Test still in `x-pack/test/detection_engine_api_integration`**\r\n1. #168415. #164318. #164313. #145776. #151636 Flaky test runner link\r\n\r\nPart 1 - `x-pack/test/detection_engine_api_integration` - tests not yet\r\nmigrated\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3597\r\nPart 2 - `x-pack/test/security_solution_api_integration` - tests already\r\nmoved\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631","sha":"9eff64a39120e364a4f9a6b71d9501dbb1be0999","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Detections and Resp","Team:Detection Engine","v8.11.0","v8.12.0"],"number":169262,"url":"#169262 Solution] Unskip tests for Detection Engine and Security Solution API Integration tests (#169262)\n\n## Summary\r\n\r\n### Changes\r\n\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/group4/telemetry/task_based/detection_rules.ts`\r\n**unskipped**\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/machine_learning.ts`\r\n**unskipped**\r\n\r\n### Related flaky test issues\r\n\r\n**Tests already moved to\r\n`x-pack/test/security_solution_api_integration`**\r\n\r\n1. #169055. #168775 issue is reported for the legacy test, but is now moved to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/ips_text_array/text_array.ts`\r\n3. #163511 issue is reported for the legacy test, but is now moved to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/keyword.ts`\r\n\r\n- Flaky test runner for above tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631\r\n\r\n**Test still in `x-pack/test/detection_engine_api_integration`**\r\n1. #168415. #164318. #164313. #145776. #151636 Flaky test runner link\r\n\r\nPart 1 - `x-pack/test/detection_engine_api_integration` - tests not yet\r\nmigrated\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3597\r\nPart 2 - `x-pack/test/security_solution_api_integration` - tests already\r\nmoved\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631","sha":"9eff64a39120e364a4f9a6b71d9501dbb1be0999"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"#169262 Solution] Unskip tests for Detection Engine and Security Solution API Integration tests (#169262)\n\n## Summary\r\n\r\n### Changes\r\n\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/group4/telemetry/task_based/detection_rules.ts`\r\n**unskipped**\r\n-\r\n`x-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/machine_learning.ts`\r\n**unskipped**\r\n\r\n### Related flaky test issues\r\n\r\n**Tests already moved to\r\n`x-pack/test/security_solution_api_integration`**\r\n\r\n1. #169055. #168775 issue is reported for the legacy test, but is now moved to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/ips_text_array/text_array.ts`\r\n3. #163511 issue is reported for the legacy test, but is now moved to\r\n`x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/keyword.ts`\r\n\r\n- Flaky test runner for above tests:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631\r\n\r\n**Test still in `x-pack/test/detection_engine_api_integration`**\r\n1. #168415. #164318. #164313. #145776. #151636 Flaky test runner link\r\n\r\nPart 1 - `x-pack/test/detection_engine_api_integration` - tests not yet\r\nmigrated\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3597\r\nPart 2 - `x-pack/test/security_solution_api_integration` - tests already\r\nmoved\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631","sha":"9eff64a39120e364a4f9a6b71d9501dbb1be0999"}}]}] BACKPORT--> Co-authored-by: Juan Pablo Djeredjian <jpdjeredjian@gmail.com>
awahab07
pushed a commit
to awahab07/kibana
that referenced
this pull request
Oct 31, 2023
…lution API Integration tests (elastic#169262) ## Summary ### Changes - `x-pack/test/detection_engine_api_integration/security_and_spaces/group4/telemetry/task_based/detection_rules.ts` **unskipped** - `x-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/machine_learning.ts` **unskipped** ### Related flaky test issues **Tests already moved to `x-pack/test/security_solution_api_integration`** 1. elastic#169055 2. elastic#168775 This issue is reported for the legacy test, but is now moved to `x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/ips_text_array/text_array.ts` 3. elastic#163511 This issue is reported for the legacy test, but is now moved to `x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/keyword.ts` - Flaky test runner for above tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631 **Test still in `x-pack/test/detection_engine_api_integration`** 1. elastic#168415 2. elastic#164318 3. elastic#164313 4. elastic#145776 **Other** 1. elastic#151636 ## Flaky test runner link Part 1 - `x-pack/test/detection_engine_api_integration` - tests not yet migrated https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3597 Part 2 - `x-pack/test/security_solution_api_integration` - tests already moved https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:fix
Team:Detection Engine
Security Solution Detection Engine Area
Team:Detections and Resp
Security Detection Response Team
v8.11.0
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
x-pack/test/detection_engine_api_integration/security_and_spaces/group4/telemetry/task_based/detection_rules.ts
unskippedx-pack/test/detection_engine_api_integration/security_and_spaces/rule_execution_logic/machine_learning.ts
unskippedRelated flaky test issues
Tests already moved to
x-pack/test/security_solution_api_integration
rule_default
exception list to a rule if one not already found #169055This issue is reported for the legacy test, but is now moved to
x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/ips_text_array/text_array.ts
This issue is reported for the legacy test, but is now moved to
x-pack/test/security_solution_api_integration/test_suites/detections_response/default_license/exceptions/operators_data_types/keyword_text_long/keyword.ts
Test still in
x-pack/test/detection_engine_api_integration
Other
Flaky test runner link
Part 1 -
x-pack/test/detection_engine_api_integration
- tests not yet migratedhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3597
Part 2 -
x-pack/test/security_solution_api_integration
- tests already movedhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3631