Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Output secrets UI #169429

Merged
merged 38 commits into from Oct 25, 2023
Merged

[Fleet] Output secrets UI #169429

merged 38 commits into from Oct 25, 2023

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Oct 19, 2023

Summary

Continuation of #169221. Part of #157458

Note: The experimental feature flag outputSecretsStorage must be enabled to see these changes.

Introduces the UI components to create and edit output secrets, currently there are only 3 output secrets:

  • Kafka output password
  • Kafka output SSL key
  • Logstash output SSL key

Some key behaviours of the new UI:

  • on creating an output, the user can opt to revert to using plain text values if they want
  • once an output has been created with a secret, when editing the output, the secret values can only be replaced, never viewed
  • If an output uses plain values, there currently isn't a way to convert to using secrets.

Create
Screenshot 2023-10-24 at 14 48 49

Edit

edit_output_secret.mov

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@hop-dev hop-dev self-assigned this Oct 24, 2023
@hop-dev hop-dev changed the title Output secrets UI [Fleet] Output secrets UI Oct 24, 2023
@hop-dev hop-dev added Team:Fleet Team label for Observability Data Collection Fleet team release_note:feature Makes this part of the condensed release notes labels Oct 24, 2023
@hop-dev hop-dev marked this pull request as ready for review October 24, 2023 14:15
@hop-dev hop-dev requested a review from a team as a code owner October 24, 2023 14:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich self-requested a review October 24, 2023 18:13
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, and I tested locally 🚀 - Nice work on this!

@hop-dev hop-dev enabled auto-merge (squash) October 25, 2023 10:32
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #4 / ALL - Live Query Packs should run live pack should run live pack
  • [job] [logs] FTR Configs #51 / Profiling API tests functions.spec.ts cloud Loading profiling data Functions api "before all" hook in "Functions api"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 940 941 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +4.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 147.6KB 148.2KB +635.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@hop-dev hop-dev merged commit eaddc54 into elastic:main Oct 25, 2023
29 of 30 checks passed
@hop-dev hop-dev deleted the output-secrets-ui branch October 25, 2023 11:54
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants