New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Output secrets UI #169429
[Fleet] Output secrets UI #169429
Conversation
(cherry picked from commit 73afbd1)
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, and I tested locally 🚀 - Nice work on this!
...ublic/applications/fleet/sections/settings/components/edit_output_flyout/use_output_form.tsx
Outdated
Show resolved
Hide resolved
...ations/fleet/sections/settings/components/edit_output_flyout/output_form_secret_form_row.tsx
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @hop-dev |
Summary
Continuation of #169221. Part of #157458
Note: The experimental feature flag
outputSecretsStorage
must be enabled to see these changes.Introduces the UI components to create and edit output secrets, currently there are only 3 output secrets:
Some key behaviours of the new UI:
Create
Edit
edit_output_secret.mov