Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add solution selection to maintenance windows #169441

Merged
merged 7 commits into from
Nov 3, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 19, 2023

Summary

Relates to #166301

This PR:

  • Updates the maintenance window documentation to mention category-specific options and refreshes the automated screenshot
  • Adds the category property in the get rule types API documentation
  • Updates the rules API specifications to include the category property in the get rule types API response

NOTE: I have also added missing alerts, has_alerts_mappings:, and has_fields_for_a_a_d properties to the rule types API response. I have not added descriptions at this time, so I'll need to investigate their purpose and add descriptions in a subsequent PR.

Preview

https://kibana_169441.docs-preview.app.elstc.co/diff

@lcawl lcawl added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs backport:prev-minor Backport to the previous minor version (i.e. one version back from main) v8.11.0 v8.12.0 labels Oct 19, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review October 26, 2023 20:27
@lcawl lcawl requested a review from a team as a code owner October 26, 2023 20:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from JiaweiWu October 26, 2023 20:42
Copy link
Contributor

@JiaweiWu JiaweiWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit 89dd696 into elastic:main Nov 3, 2023
29 checks passed
@lcawl lcawl deleted the maint-window-scope branch November 3, 2023 18:36
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 3, 2023
lcawl added a commit to kibanamachine/kibana that referenced this pull request Nov 3, 2023
lcawl added a commit that referenced this pull request Nov 3, 2023
…#170566)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[DOCS] Add solution selection to maintenance windows
(#169441)](#169441)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"lcawley@elastic.co"},"sourceCommit":{"committedDate":"2023-11-03T18:36:55Z","message":"[DOCS]
Add solution selection to maintenance windows
(#169441)","sha":"89dd69656cd82e67f653b2bd4adf5a83ae76bf0c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","docs","backport:prev-minor","v8.11.0","v8.12.0"],"number":169441,"url":"#169441
Add solution selection to maintenance windows
(#169441)","sha":"89dd69656cd82e67f653b2bd4adf5a83ae76bf0c"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"#169441
Add solution selection to maintenance windows
(#169441)","sha":"89dd69656cd82e67f653b2bd4adf5a83ae76bf0c"}}]}]
BACKPORT-->

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants