[ML] Allows temporary data views in AD job wizards #170112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
release_note:enhancement
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
qn895
reviewed
Oct 30, 2023
...ugins/ml/public/application/jobs/new_job/pages/index_or_search/preconfigured_job_redirect.ts
Outdated
Show resolved
Hide resolved
qn895
reviewed
Oct 30, 2023
| @@ -238,7 +238,7 @@ export default function ({ getService }: FtrProviderContext) { | |||
| await ml.testExecution.logTestStep( | |||
| 'job cloning clicks the clone action and displays an error toast' | |||
There was a problem hiding this comment.
We probably should update the log test step here to reflect that it is opening the wizard
There was a problem hiding this comment.
Updated in 5773dd2
qn895
reviewed
Oct 30, 2023
x-pack/test/functional/apps/ml/anomaly_detection_jobs/single_metric_job.ts
Outdated
Show resolved
Hide resolved
…etric_job.ts Co-authored-by: Quynh Nguyen (Quinn) <43350163+qn895@users.noreply.github.com>
|
We currently disable the link from the anomalies table to Discover if no data view exists for the job? Is it possible to link to Discover in such a way that Discover can create a temporary data view? |
@peteharverson I've updated this here |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
qn895
approved these changes
Oct 31, 2023
|
Code LGTM 🎉 |
peteharverson
approved these changes
Oct 31, 2023
jgowdyelastic
deleted the
allow-temprary-data-views-for-AD-job-creation
branch
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
When creating a brand new job, temporary data views can be created and used in the wizard. When cloning a job where the data view cannot be found, a new temporary data view is created to be used in the wizard. This can happen if the data view used to create the original job has been deleted or the job was created with a temporary data view. https://github.com/elastic/kibana/assets/22172091/2b9c2125-2b0c-449d-a226-82267f64567b Also overrides the animation for the expanded rows in the AD jobs list which can cause strange behaviour when changing tabs in the expanded row. --------- Co-authored-by: Quynh Nguyen (Quinn) <43350163+qn895@users.noreply.github.com>
szabosteve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a brand new job, temporary data views can be created and used in the wizard.
When cloning a job where the data view cannot be found, a new temporary data view is created to be used in the wizard.
This can happen if the data view used to create the original job has been deleted or the job was created with a temporary data view.
2023-10-30.11-09-20.2023-10-30.11_09_57.mp4
Also overrides the animation for the expanded rows in the AD jobs list which can cause strange behaviour when changing tabs in the expanded row.