Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Unskips detection_page_filters tests #170163

Merged
merged 6 commits into from
Nov 6, 2023
Merged

[Security Solution] Unskips detection_page_filters tests #170163

merged 6 commits into from
Nov 6, 2023

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Oct 30, 2023 •
edited by kibanamachine
Loading

Summary

Fixes: #167914
Fixes: #167915

In this PR we are unskiping and fixing the flakiness for detection_page_filters.

The changes have been executed 100 times for ESS and 100 times for serverless and everything worked fine :)

@MadameSheema MadameSheema changed the title unskipping tests [Security Solution] Unskips detection_page_filters tests Nov 6, 2023
@MadameSheema MadameSheema self-assigned this Nov 6, 2023
@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.11.0 v8.12.0 labels Nov 6, 2023
@MadameSheema MadameSheema marked this pull request as ready for review November 6, 2023 18:41
@MadameSheema MadameSheema requested a review from a team as a code owner November 6, 2023 18:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema enabled auto-merge (squash) November 6, 2023 18:42
michaelolo24
michaelolo24 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for running them through the flaky test runner!

@MadameSheema MadameSheema merged commit 6f1fbce into elastic:main Nov 6, 2023
36 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.11 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 170163

Questions ?

Please refer to the Backport tool documentation

@MadameSheema MadameSheema deleted the unskipping-detection-page-filters branch November 6, 2023 20:25
@MadameSheema MadameSheema added backport:skip This commit does not require backporting and removed v8.11.0 labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

@MadameSheema MadameSheema

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.12.0
Projects
None yet
Milestone
No milestone
5 participants
@MadameSheema @elasticmachine @kibana-ci @kibanamachine @michaelolo24