Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][API testing] Move and restructures Risk Engine tests #170530

Merged
merged 29 commits into from
Nov 9, 2023

Conversation

WafaaNasr
Copy link
Contributor

@WafaaNasr WafaaNasr commented Nov 3, 2023

Summary

Following the initial work in this #166755

  • Addresses part of [Security Solution] Restructure API integration tests into meaningful groups that run in parallel on CI #151902 for Entity Analytics/Risk Engine
  • Introduced new folders called entity_analytics/risk_engine under security_solution_api_integration
  • Moved the utility files associated with risk_engine to the new directory security_solution_api_integration. Files that were not actively used in the previous folder were moved, while any duplicate files remained in their original positions.
  • Updated the CodeOwner file for the newly moved tests
  • Old / new groups details and execution time document
Action File New Path if moved
Moved group10/risk_engine/init_and_status_apis /entity_analytics/default_license/risk_engine/init_and_status_apis.ts
Moved group10/risk_engine/risk_score_calculation /entity_analytics/default_license/risk_engine/risk_score_calculation.ts
Moved group10/risk_engine/risk_score_preview /entity_analytics/default_license/risk_engine/risk_score_preview.ts
Moved group10/risk_engine/risk_scoring_task_execution /entity_analytics/default_license/risk_engine/risk_scoring_task_execution.ts
Moved group10/risk_engine/telemetry_usage /entity_analytics/default_license/risk_engine/telemetry_usage.ts
Moved group10/risk_engine/utils entity_analytics/utils/risk_engine.ts
Moved utils/get_stats entity_analytics/utils/get_risk_engine_stats.ts

Tests skipped on main:

https://github.com/elastic/kibana/blob/main/x-pack/test/detection_engine_api_integration/security_and_spaces/group10/risk_engine/init_and_status_apis.ts#L363

@WafaaNasr WafaaNasr added release_note:skip Skip the PR/issue when compiling release notes FTR labels Nov 3, 2023
@WafaaNasr WafaaNasr self-assigned this Nov 3, 2023
kibanamachine and others added 22 commits November 3, 2023 14:34
@WafaaNasr WafaaNasr marked this pull request as ready for review November 8, 2023 17:31
@WafaaNasr WafaaNasr requested review from a team as code owners November 8, 2023 17:31
@WafaaNasr WafaaNasr requested a review from a team as a code owner November 8, 2023 17:31
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftr_configs.yml

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @WafaaNasr

Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for your work!

@WafaaNasr WafaaNasr merged commit eeaf815 into elastic:main Nov 9, 2023
25 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 9, 2023
@WafaaNasr WafaaNasr deleted the move-structure-risk_engine_apis branch November 9, 2023 13:53
tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Nov 9, 2023
…sts (elastic#170530)

## Summary

Following the initial work in this
elastic#166755
- Addresses part of elastic#151902 for
Entity Analytics/Risk Engine
- Introduced new folders called `entity_analytics/risk_engine` under
`security_solution_api_integration`
- Moved the utility files associated with risk_engine to the new
directory `security_solution_api_integration`. Files that were not
actively used in the previous folder were moved, while any duplicate
files remained in their original positions.
- Updated the CodeOwner file for the newly moved tests
- Old / new groups details and execution time
[document](https://docs.google.com/document/d/1CRFfDWMzw3ob03euWIvT4-IoiLXjoiPWI8mTBqP4Zks/edit)


| Action | File | New Path if moved |
|--------|------|----------|
| Moved|
group10/risk_engine/init_and_status_apis|/entity_analytics/default_license/risk_engine/init_and_status_apis.ts
|
| Moved|
group10/risk_engine/risk_score_calculation|/entity_analytics/default_license/risk_engine/risk_score_calculation.ts
|
| Moved|
group10/risk_engine/risk_score_preview|/entity_analytics/default_license/risk_engine/risk_score_preview.ts
|
| Moved|
group10/risk_engine/risk_scoring_task_execution|/entity_analytics/default_license/risk_engine/risk_scoring_task_execution.ts
|
| Moved|
group10/risk_engine/telemetry_usage|/entity_analytics/default_license/risk_engine/telemetry_usage.ts
|
| Moved| group10/risk_engine/utils|entity_analytics/utils/risk_engine.ts
|
| Moved| utils/get_stats|entity_analytics/utils/get_risk_engine_stats.ts
|

Tests skipped on main:


https://github.com/elastic/kibana/blob/main/x-pack/test/detection_engine_api_integration/security_and_spaces/group10/risk_engine/init_and_status_apis.ts#L363

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Nikita Khristinin <nkhristinin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants