Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] fix servicenow itsm cases fields flaky test #170537

Merged
merged 8 commits into from
Nov 6, 2023
Merged

[Cases] fix servicenow itsm cases fields flaky test #170537

merged 8 commits into from
Nov 6, 2023

Conversation

js-jankisalvi
Copy link
Contributor

@js-jankisalvi js-jankisalvi commented Nov 3, 2023 •
edited
Loading

Summary

Use use await findByTestId to fix flaky tests

fixes #167384
fixes #167385

Checklist

For maintainers

@js-jankisalvi js-jankisalvi added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.12.0 labels Nov 3, 2023
@js-jankisalvi js-jankisalvi requested a review from a team as a code owner November 3, 2023 15:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@js-jankisalvi js-jankisalvi self-assigned this Nov 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@js-jankisalvi js-jankisalvi enabled auto-merge (squash) November 6, 2023 08:23
@js-jankisalvi js-jankisalvi changed the title [Cases] fix serviceNow connector flaky test [Cases] fix serviceNow itsm connector flaky test Nov 6, 2023
@js-jankisalvi js-jankisalvi changed the title [Cases] fix serviceNow itsm connector flaky test [Cases] fix servicenow itsm cases fields flaky test Nov 6, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

@js-jankisalvi js-jankisalvi merged commit 42fc7ea into elastic:main Nov 6, 2023
26 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 6, 2023
@js-jankisalvi js-jankisalvi deleted the servicenow-flaky-test branch January 24, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees

@js-jankisalvi js-jankisalvi

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
None yet
Milestone
No milestone
5 participants
@js-jankisalvi @elasticmachine @kibana-ci @cnasikas @kibanamachine