Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Detection Engine: Enable remaining Cypress tests and skip flaky Cypress tests #170540

Merged
merged 9 commits into from
Nov 8, 2023

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Nov 3, 2023

Summary

  • skips flaky can bulk open alerts test on x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts/alert_status.cy.ts
  • enables serverless for: x-pack/test/security_solution_cypress/cypress/e2e/exceptions/rule_details_flow/add_edit_endpoint_exception.cy.ts
  • removes outdated comments

For maintainers

@jpdjere jpdjere requested a review from a team as a code owner November 3, 2023 15:54
@jpdjere jpdjere marked this pull request as draft November 3, 2023 15:55
@jpdjere jpdjere changed the title [Security Solution] Skip remaining flaky Detection Engine Cypress tests [Security Solution] Detection Engine: Enable remaining Cypress tests and skip flaky Cypress tests Nov 6, 2023
@jpdjere jpdjere self-assigned this Nov 6, 2023
@jpdjere jpdjere added v8.11.0 v8.12.0 Team:Detections and Resp Security Detection Response Team Team:Detection Engine Security Solution Detection Engine Area release_note:skip Skip the PR/issue when compiling release notes test Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 6, 2023
@jpdjere jpdjere marked this pull request as ready for review November 6, 2023 12:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@@ -80,7 +79,7 @@ describe('Changing alert status', { tags: ['@ess', '@serverless'] }, () => {
});
});

it('can bulk open alerts', () => {
it.skip('can bulk open alerts', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just create a ticket to track the skip and add here in a comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, adding to the code.

Ticket: #169091 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: I skipped the whole suite as it started showing signs of flake again.

See ticket.

Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small ask!

@jpdjere
Copy link
Contributor Author

jpdjere commented Nov 7, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #3 / Ransomware Detection Alerts Ransomware in Timelines Renders ransomware entries in timelines table Renders ransomware entries in timelines table

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

@jpdjere jpdjere added v8.11.1 and removed v8.11.0 labels Nov 8, 2023
@jpdjere jpdjere merged commit 0063691 into elastic:main Nov 8, 2023
28 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.11 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 170540

Questions ?

Please refer to the Backport tool documentation

@jpdjere jpdjere removed the v8.11.1 label Nov 9, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 9, 2023
@jpdjere
Copy link
Contributor Author

jpdjere commented Nov 9, 2023

#170540 (comment)

Not creating backport to 8.11 as not applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants