Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless nav] Remove trailing forward slash in Cloud URLs #170617

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Nov 6, 2023

This PR fixes broken navigation in Cloud UI when navigating there from a serverless project.

I've decided to not change the current URLs being injected in Kibana as a measure of precaution in cases those are used somewhere (expecting the trailing "/"). Instead I parse the URLs that that are then used as href attributes.

Fixes #170475

@sebelga sebelga self-assigned this Nov 6, 2023
@sebelga sebelga added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release Project:Serverless MVP release_note:skip Skip the PR/issue when compiling release notes labels Nov 6, 2023
@sebelga sebelga marked this pull request as ready for review November 6, 2023 10:21
@sebelga sebelga requested a review from a team as a code owner November 6, 2023 10:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@sebelga sebelga requested a review from eokoneyo November 6, 2023 10:23
Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good and resolves issue

Screenshot 2023-11-06 at 12 18 35

@sebelga
Copy link
Contributor Author

sebelga commented Nov 6, 2023

Thanks for the review @eokoneyo !

@sebelga sebelga enabled auto-merge (squash) November 6, 2023 11:39
@sebelga sebelga merged commit b562839 into elastic:main Nov 6, 2023
35 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolutionServerless 336.6KB 336.8KB +253.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/shared-ux-chrome-navigation 4 5 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
serverlessObservability 63.1KB 63.3KB +253.0B
serverlessSearch 49.5KB 49.8KB +253.0B
total +506.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 6, 2023
@sebelga sebelga deleted the serverless-chrome/fix-cloud-urls branch November 7, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Serverless MVP Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Serverless] Remove trailing slash from billing overview link in management
5 participants