Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average mobile app launch #170773

Merged
merged 17 commits into from Nov 9, 2023

Conversation

LikeTheSalad
Copy link
Contributor

@LikeTheSalad LikeTheSalad commented Nov 7, 2023

Summary

Enabled the "Average app load time" panel in the mobile dashboard.

Screenshot 2023-11-08 at 18 35 12

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@LikeTheSalad LikeTheSalad marked this pull request as ready for review November 7, 2023 16:52
@LikeTheSalad LikeTheSalad requested a review from a team as a code owner November 7, 2023 16:52
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@LikeTheSalad
Copy link
Contributor Author

@elasticmachine merge upstream

@LikeTheSalad LikeTheSalad requested a review from a team as a code owner November 8, 2023 17:43
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small comment about the variable name other than that LGTM, thanks @LikeTheSalad 🔥

@LikeTheSalad
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.7MB 3.7MB +320.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@LikeTheSalad LikeTheSalad merged commit 5c44377 into elastic:main Nov 9, 2023
27 checks passed
@LikeTheSalad LikeTheSalad deleted the average-mobile-app-launch branch November 9, 2023 10:16
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 9, 2023
tkajtoch pushed a commit to tkajtoch/kibana that referenced this pull request Nov 9, 2023
## Summary

Enabled the "Average app load time" panel in the mobile dashboard.

![Screenshot 2023-11-08 at 18 35
12](https://github.com/elastic/kibana/assets/56847527/4ae1b05b-d71b-47e2-9f11-a884251de975)

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Katerina <kate@kpatticha.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review backport:skip This commit does not require backporting release_note:enhancement Team:APM All issues that need APM UI Team support v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants