On search source error, show 'view details' action that opens request in inspector

[nreese]

Closes #167904

PR updates EsError with getActions method that returns "View details" button. Clicking "View details" opens inspector to request that failed. PR updates Discover and maps to display EsError action.

PR does not update lens to display "View details". Chatted with @drewdaemon and the implementation path is more involved. This will be completed in another PR.

Test setup

1. install sample web logs

Test discover with EsError

1. open discover
2. Add filter

   {
     "error_query": {
       "indices": [
         {
           "error_type": "exception",
           "message": "local shard failure message 123",
           "name": "kibana_sample_data_logs"
         }
       ]
     }
   }
   

3. Verify View details action is displayed and clicking action opens inspector
   

Test search embeddable with EsError

1. create new dashboard. Add saved search from kibana_sample_data_logs data view
2. Add filter

   {
     "error_query": {
       "indices": [
         {
           "error_type": "exception",
           "message": "local shard failure message 123",
           "name": "kibana_sample_data_logs"
         }
       ]
     }
   }
   

3. Verify View details action is displayed and clicking action opens inspector
   

Test discover with PainlessError

Test Maps error

1. create new map
2. Add documents layer
3. Set scaling to "limit to 10000"
4. Add filter

   {
     "error_query": {
       "indices": [
         {
           "error_type": "exception",
           "message": "local shard failure message 123",
           "name": "kibana_sample_data_logs"
         }
       ]
     }
   }
   

5. Verify "View details" button is displayed in maps legend in error callout
   

[nreese]

@elasticmachine merge upstream

[nreese]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[stratoula]

I will leave the review to the Discovery team which owns search

[lukasolson]

It looks like we're still missing at least one error. Steps to reproduce:

1. Ingest a nested document:

PUT my-index-000001
{
  "mappings": {
    "properties": {
      "user": {
        "type": "nested" 
      }
    }
  }
}

POST my-index-000001/_doc
{
  "group" : "fans",
  "user" : [
    {
      "first" : "John",
      "last" :  "Smith"
    },
    {
      "first" : "Alice",
      "last" :  "White"
    }
  ]
}

2. Try to query using incorrect KQL syntax: user.last.keyword : "Smith"

Here's the error:

And here's what you get when clicking "View details":

[nreese]

@lukasolson

It looks like we're still missing at least one error. Steps to reproduce:

Thanks for the example error. In this case, the error is not an EsError instance, but rather an error thrown by KQL. The error is thrown before search_source.fetch is called so there is never a request/response from elasticsearch.

The "View details" is button is the one from discover error callout. The think the current behavior is expected since there is nothing to view in the inspector since the request never made it to elasticsearch.

[lukasolson]

The error is thrown before search_source.fetch is called so there is never a request/response from elasticsearch.

Makes sense, thanks for the explanation!

LGTM

[ThomThomson]

Presentation team changes LGTM! Tested this locally in chrome and the view details button appears when expected and works as expected. Also looked through the code, and everything looks great. Left one nit.

[nreese]

@elasticmachine merge upstream

[nreese]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 24f5cde

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
embeddable	116	115	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
data	46.9KB	46.9KB	+1.0B
discover	590.3KB	590.3KB	+63.0B
maps	2.9MB	2.9MB	+662.0B
total			+726.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	413.3KB	414.3KB	+1.1KB
embeddable	78.4KB	78.5KB	+144.0B
total			+1.2KB

History

• 💔 Build #175812 failed cf10373
• 💛 Build #174996 was flaky 291d9b8
• 💚 Build #174767 succeeded 5e02ec2
• 💛 Build #174733 was flaky 90ebaa3
• 💔 Build #174423 failed 12a1f38

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream