Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Kibana context types clean up #170868

Merged
merged 8 commits into from Nov 9, 2023
Merged

[ML] Kibana context types clean up #170868

merged 8 commits into from Nov 9, 2023

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Nov 8, 2023 •
edited

Corrects the types describing the services added to ML's kibana context.

Most of the churn here is me alphabetically sorting the lists of dependencies.
Also Removes appName from the context as it was never actually set. In the places where it was being used I've switched to our PLUGIN_ID

@jgowdyelastic jgowdyelastic self-assigned this Nov 8, 2023
@jgowdyelastic jgowdyelastic added chore non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.12.0 labels Nov 8, 2023
@jgowdyelastic jgowdyelastic marked this pull request as ready for review November 8, 2023 14:16
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner November 8, 2023 14:16
@jgowdyelastic jgowdyelastic requested review from a team as code owners November 8, 2023 15:00
@jgowdyelastic jgowdyelastic removed request for a team November 8, 2023 16:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic removed the non-issue Indicates to automation that a pull request should not appear in the release notes label Nov 8, 2023
peteharverson
peteharverson approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, but otherwise code LGTM

x-pack/plugins/ml/public/application/app.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ml/public/application/contexts/kibana/kibana_context.ts Outdated Show resolved Hide resolved
walterra
walterra approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +13.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 91c50c2 into elastic:main Nov 9, 2023
27 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 9, 2023
@jgowdyelastic jgowdyelastic deleted the type-clean-up branch November 9, 2023 16:14
@logeekal logeekal mentioned this pull request Nov 16, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting chore :ml release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @walterra @peteharverson @kibanamachine