[Lens] [Unified Search] Fix field truncation on Combo boxes #170889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
mbondyra
force-pushed
the
lens/truncate_fixes
branch
7 times, most recently
from
338bd7f
to
ee9be1b
Compare
mbondyra
added
loe:medium
mbondyra
force-pushed
the
lens/truncate_fixes
branch
from
ee9be1b
to
d3a7379
Compare
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
mbondyra
force-pushed
the
lens/truncate_fixes
branch
from
53f969c
to
23fe8af
Compare
mbondyra
force-pushed
the
lens/truncate_fixes
branch
from
23fe8af
to
f9a2e6d
Compare
dej611
reviewed
Nov 14, 2023
There was a problem hiding this comment.
I see a general improvement with this PR with all fields with long names.
Found some bugs, but unsure whether they are strictly related with the scope of this PR or need to be fixed in a next iteration (either way I'm fine):
- If the selected field name is very long it can overflow the filter popover
(On Edge browser)
(On Safari browser)
- it seems values are now showing up in the filter values section:
But I see values when aggregating:
|
|
||
| return ( | ||
| <div ref={comboBoxRef}> | ||
| <div> |
There was a problem hiding this comment.
you're right, nope!
dej611
approved these changes
Nov 15, 2023
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
jillguyonnet
pushed a commit
to jillguyonnet/kibana
that referenced
this pull request
Nov 16, 2023
…170889) ## Summary Fixes 3/5 of elastic#168753 Doesn't set up multilines. Doesn't remove auto-expanding logic. Middle truncates. (Unified Search) Field selector <img width="984" alt="Screenshot 2023-11-13 at 11 30 20" src="https://github.com/elastic/kibana/assets/4283304/9acb6462-3205-4e5c-81bd-c3ae10c8323b"> (Unified Search) Value selector: <img width="972" alt="Screenshot 2023-11-13 at 11 30 30" src="https://github.com/elastic/kibana/assets/4283304/e58b09de-d582-431f-bbd6-97b7c5bd38de"> (Lens) Field picker within layer config: <img width="346" alt="Screenshot 2023-11-09 at 14 44 58" src="https://github.com/elastic/kibana/assets/4283304/4ecb0ea5-bb01-49e3-a54f-4c8c5884c418"> Also fixes tiny stylistic issue for dataview picker label cut on the bottom: <img width="368" alt="Screenshot 2023-11-09 at 15 06 38" src="https://github.com/elastic/kibana/assets/4283304/b9ae6956-c1ef-481e-905d-71ffe5e5545a"> <img width="386" alt="Screenshot 2023-11-09 at 15 07 08" src="https://github.com/elastic/kibana/assets/4283304/5d49ed7a-e8f2-40c1-ac53-a3580b82740e">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3/5 of #168753
Doesn't set up multilines. Doesn't remove auto-expanding logic. Middle truncates.
(Unified Search) Field selector
(Unified Search) Value selector:
(Lens) Field picker within layer config:
Also fixes tiny stylistic issue for dataview picker label cut on the bottom:
