[Profiling] adding KQL bar to embeddables

[cauemarcondes]

Adding KQL bar to the Flamegraph and Top 10 functions embeddable.

kql.mov

New version:

[elasticmachine]

Pinging @elastic/apm-ui (Team:APM)

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[mykolaharmash]

Looks good ✨ Only a couple of minor comments.

[crespocarlos]

LGMT!

In the description, could we add the steps to test the PR? I believe it would help reviewers get up to speed with working on Profiling in general.

[kpatticha]

tried lucene by accident and it seems it doesn't work

Also, out of curiosity, why you didn't export the search bar as an embeddable? I think exporting the components provides greater flexibility in integrating and customizing the UI.

[cauemarcondes]

Also, out of curiosity, why you didn't export the search bar as an embeddable? I think exporting the components provides greater flexibility in integrating and customizing the UI.

Do you see the Profiling kuery bar being used independently in any plugin? I think the kuery bar will always be used together with another Profiling component to filter its result down. That is the reason I did not create a new embeddable for the kuery bar itself.

[kpatticha]

Also, out of curiosity, why you didn't export the search bar as an embeddable? I think exporting the components provides greater flexibility in integrating and customizing the UI.

Do you see the Profiling kuery bar being used independently in any plugin? I think the kuery bar will always be used together with another Profiling component to filter its result down. That is the reason I did not create a new embeddable for the kuery bar itself.

Not really, I expect that the profiling search bar will always be used with another Profiling component.

However, here is an example of Alerts exporting the search bar https://github.com/elastic/kibana/blob/2a8a68c1f8d14074d23ca9feef118aa172191bfe/x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx#L85C14-L101 (it doesn't have to be the same for profiling, I was just curious)

[cauemarcondes]

Not really, I expect that the profiling search bar will always be used with another Profiling component.

However, here is an example of Alerts exporting the search bar https://github.com/elastic/kibana/blob/2a8a68c1f8d14074d23ca9feef118aa172191bfe/x-pack/plugins/apm/public/components/app/alerts_overview/index.tsx#L85C14-L101 (it doesn't have to be the same for profiling, I was just curious)

The advantage I see is the client will be able to position the kuery bar wherever they want. We could place it on top of the tabs for example.

[cauemarcondes]

Ok, after talking to @iogbole we agreed that would be better to display the Profiling kuery bar on top of the Tabs, also to keep it consistent with the other pages. Thanks for raising it up @kpatticha.

[cauemarcondes]

@elasticmachine run elasticsearch-ci/docs

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 47435fb

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
observabilityShared	131	132	+1
profiling	213	215	+2
total			+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
observabilityShared	289	301	+12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	3.7MB	3.7MB	+367.0B
profiling	365.8KB	369.2KB	+3.4KB
serverlessSearch	369.1KB	369.2KB	+147.0B
total			+3.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
observabilityShared	47.3KB	48.0KB	+782.0B
profiling	18.7KB	19.2KB	+532.0B
total			+1.3KB

Unknown metric groups

API count

id	before	after	diff
observabilityShared	292	305	+13

async chunk count

id	before	after	diff
profiling	6	7	+1

ESLint disabled line counts

id	before	after	diff
observabilityShared	9	10	+1

Total ESLint disabled count

id	before	after	diff
observabilityShared	9	10	+1

History

• 💔 Build #178136 failed 6c1fca6
• 💛 Build #177859 was flaky d68f20e
• 💔 Build #177451 failed 08187e2
• 💛 Build #177236 was flaky ea67898
• 💛 Build #176872 was flaky 8d9771a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream