[ML] Transforms/Data frame analytics: Aligns data view / destination index creation workflow in wizards #171202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
force-pushed
the
160593-ml-consolidate-data-view-creation-workflow
branch
5 times, most recently
from
c6cafa2
to
76aa596
Compare
|
I accidentally switched this one to review but it's not finished yet, reverting back to draft and will ping reviewers later again. |
walterra
force-pushed
the
160593-ml-consolidate-data-view-creation-workflow
branch
7 times, most recently
from
0b031ff
to
35ab565
Compare
walterra
changed the title
|
Pinging @elastic/ml-ui (:ml) |
walterra
force-pushed
the
160593-ml-consolidate-data-view-creation-workflow
branch
from
eb2a81f
to
49d6b79
Compare
x-pack/packages/ml/data_view_utils/components/create_data_view_switch.tsx
Show resolved
Hide resolved
|
@peteharverson Thanks for catching the missing data view section in the JSON editor. Added the section to create data views back to the JSON editor variant. Also updated the toggle to auto-start the DFA job from checkbox to switch to be in line with the updated data view UI. 
|
...ication/data_frame_analytics/pages/analytics_creation/components/create_step/create_step.tsx
Outdated
Show resolved
Hide resolved
peteharverson
approved these changes
Nov 29, 2023
peteharverson
changed the title
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
walterra
deleted the
160593-ml-consolidate-data-view-creation-workflow
branch
szabosteve
changed the title
szabosteve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #160593.
Consolidates UI elements and backend code to create/delete data views and destination indices related to transforms and data frame analytics.
We ended up with two different approaches for creating data views in the wizards for transforms and data frame analytics, the original reason was we were not aware of the
allowNoIndex: truesetting and worked around that in different ways.This PR aligns UI workflows and moves related code to a new package
@kbn/ml-data-view-utilsfor data views and@kbn/ml-creation-wizard-utilsfor the destination index form. The latter might be used for other shared components across wizard..In Data Frame Analytics, the checkbox to create a data view was removed from the last "Create" step, instead the option to create a data view was moved to the "Details" step.
In Transforms, the UI component to create the destination index was brought over from DFA where there is a switch option to automatically use the job ID as the name for the destination index by default.
Updated data frame analytics wizard:
Updated transform wizard:
Checklist