Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] ignore indices without geometry field in vector tile requests #171472

Merged
merged 10 commits into from Nov 22, 2023

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 17, 2023

Closes #170656

PR adds exists filter to ensure geo field exists

Test instructions

  1. In console, run:
    PUT geo1
    {}
    
    PUT geo1/_mapping
    {
      "properties": {
        "location": {
          "type": "geo_point"
        }
      }
    }
    
    PUT geo1/_doc/1
    {
      "location": "25,25"
    }
    
    PUT geo2
    {}
    
    PUT geo2/_doc/1
    {}
    
  2. Create geo* data view
  3. create new map
  4. add documents layer from geo* data view.
  5. Add heatmap layer from geo* data view.
  6. Verify geo1 data is displayed and warning is not displayed fro geo2 shard failures

@nreese
Copy link
Contributor Author

nreese commented Nov 20, 2023

@elasticmachine merge upstream

@nreese nreese marked this pull request as ready for review November 20, 2023 16:38
@nreese nreese requested a review from a team as a code owner November 20, 2023 16:38
@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Maps v8.12.0 labels Nov 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Nov 20, 2023

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Nov 20, 2023

@elasticmachine merge upstream

Copy link
Member

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code and tested locally with documents, cluster, and heatmap and all layer types include the filter->exists->field condition to remove data without the geospatial field.

@nreese
Copy link
Contributor Author

nreese commented Nov 21, 2023

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Nov 22, 2023

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Nov 22, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 22, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.9MB 2.9MB +264.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 76f6dc3 into elastic:main Nov 22, 2023
33 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Maps release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[maps] ignore indices without geometry field in vector tile requests
5 participants